feat(headless): Implement GhostObjectManagerDummy (#2244)

Author: bobtista

Generals/Code/GameEngine/Include/GameLogic/GameLogic.h

@@ -348,7 +348,7 @@ class GameLogic : public SubsystemInterface, public Snapshot
 
 	/// factory for TheTerrainLogic, called from init()
 	virtual TerrainLogic *createTerrainLogic();
-	virtual GhostObjectManager *createGhostObjectManager();
+	virtual GhostObjectManager *createGhostObjectManager(bool dummy = false);
 
 	GameMode m_gameMode;
 	Int m_rankLevelLimit;

Generals/Code/GameEngine/Include/GameLogic/GhostObject.h

@@ -108,5 +108,19 @@ inline Bool GhostObjectManager::trackAllPlayers() const
 #endif
 }
 
+// TheSuperHackers @feature bobtista 19/01/2026
+// GhostObjectManager that does nothing for headless mode.
+// Note: Does NOT override crc/xfer/loadPostProcess to maintain save compatibility.
+class GhostObjectManagerDummy : public GhostObjectManager
+{
+public:
+	virtual void reset() override {}
+	virtual GhostObject *addGhostObject(Object *object, PartitionData *pd) override { return nullptr; }
+	virtual void removeGhostObject(GhostObject *mod) override {}
+	virtual void updateOrphanedObjects(int *playerIndexList, int playerIndexCount) override {}
+	virtual void releasePartitionData() override {}
+	virtual void restorePartitionData() override {}
+};
+
 // the singleton
 extern GhostObjectManager *TheGhostObjectManager;

Generals/Code/GameEngine/Source/GameLogic/System/GameLogic.cpp

@@ -353,7 +353,7 @@ void GameLogic::init()
 	// Create system for holding deleted objects that are
 	// still in the partition manager because player has a fogged
 	// view of them.
-	TheGhostObjectManager = createGhostObjectManager();
+	TheGhostObjectManager = createGhostObjectManager(TheGlobalData->m_headless);
 
 	// create the terrain logic
 	TheTerrainLogic = createTerrainLogic();
@@ -3935,8 +3935,10 @@ UnsignedInt GameLogic::getObjectCount()
 
 // ------------------------------------------------------------------------------------------------
 // ------------------------------------------------------------------------------------------------
-GhostObjectManager *GameLogic::createGhostObjectManager()
+GhostObjectManager *GameLogic::createGhostObjectManager(bool dummy)
 {
+	if (dummy)
+		return NEW GhostObjectManagerDummy;
 	return NEW GhostObjectManager;
 }
 

Generals/Code/GameEngineDevice/Include/W3DDevice/GameLogic/W3DGameLogic.h

@@ -59,6 +59,11 @@ class W3DGameLogic : public GameLogic
 
 	/// factory for TheTerrainLogic, called from init()
 	virtual TerrainLogic *createTerrainLogic() { return NEW W3DTerrainLogic; };
-	virtual GhostObjectManager *createGhostObjectManager() { return NEW W3DGhostObjectManager; }
+	virtual GhostObjectManager *createGhostObjectManager(bool dummy)
+	{
+		if (dummy)
+			return NEW GhostObjectManagerDummy;
+		return NEW W3DGhostObjectManager;
+	}
 
 };

Generals/Code/GameEngineDevice/Source/W3DDevice/GameLogic/W3DGhostObject.cpp

@@ -153,7 +153,7 @@ void W3DRenderObjectSnapshot::update(RenderObjClass *robj, DrawableInfo *drawInf
 // ------------------------------------------------------------------------------------------------
 Bool W3DRenderObjectSnapshot::addToScene()
 {
-	if (W3DDisplay::m_3DScene != nullptr && !m_robj->Is_In_Scene())
+	if (!m_robj->Is_In_Scene())
 	{
 		W3DDisplay::m_3DScene->Add_Render_Object(m_robj);
 		return true;

GeneralsMD/Code/GameEngine/Include/GameLogic/GameLogic.h

@@ -359,7 +359,7 @@ class GameLogic : public SubsystemInterface, public Snapshot
 
 	/// factory for TheTerrainLogic, called from init()
 	virtual TerrainLogic *createTerrainLogic();
-	virtual GhostObjectManager *createGhostObjectManager();
+	virtual GhostObjectManager *createGhostObjectManager(bool dummy = false);
 
 	GameMode m_gameMode;
 	Int m_rankLevelLimit;

GeneralsMD/Code/GameEngine/Include/GameLogic/GhostObject.h

@@ -108,5 +108,19 @@ inline Bool GhostObjectManager::trackAllPlayers() const
 #endif
 }
 
+// TheSuperHackers @feature bobtista 19/01/2026
+// GhostObjectManager that does nothing for headless mode.
+// Note: Does NOT override crc/xfer/loadPostProcess to maintain save compatibility.
+class GhostObjectManagerDummy : public GhostObjectManager
+{
+public:
+	virtual void reset() override {}
+	virtual GhostObject *addGhostObject(Object *object, PartitionData *pd) override { return nullptr; }
+	virtual void removeGhostObject(GhostObject *mod) override {}
+	virtual void updateOrphanedObjects(int *playerIndexList, int playerIndexCount) override {}
+	virtual void releasePartitionData() override {}
+	virtual void restorePartitionData() override {}
+};
+
 // the singleton
 extern GhostObjectManager *TheGhostObjectManager;

GeneralsMD/Code/GameEngine/Source/GameLogic/System/GameLogic.cpp

@@ -364,7 +364,7 @@ void GameLogic::init()
 	// Create system for holding deleted objects that are
 	// still in the partition manager because player has a fogged
 	// view of them.
-	TheGhostObjectManager = createGhostObjectManager();
+	TheGhostObjectManager = createGhostObjectManager(TheGlobalData->m_headless);
 
 	// create the terrain logic
 	TheTerrainLogic = createTerrainLogic();
@@ -4492,8 +4492,10 @@ UnsignedInt GameLogic::getObjectCount()
 
 // ------------------------------------------------------------------------------------------------
 // ------------------------------------------------------------------------------------------------
-GhostObjectManager *GameLogic::createGhostObjectManager()
+GhostObjectManager *GameLogic::createGhostObjectManager(bool dummy)
 {
+	if (dummy)
+		return NEW GhostObjectManagerDummy;
 	return NEW GhostObjectManager;
 }
 

GeneralsMD/Code/GameEngineDevice/Include/W3DDevice/GameLogic/W3DGameLogic.h

@@ -59,6 +59,11 @@ class W3DGameLogic : public GameLogic
 
 	/// factory for TheTerrainLogic, called from init()
 	virtual TerrainLogic *createTerrainLogic() { return NEW W3DTerrainLogic; };
-	virtual GhostObjectManager *createGhostObjectManager() { return NEW W3DGhostObjectManager; }
+	virtual GhostObjectManager *createGhostObjectManager(bool dummy)
+	{
+		if (dummy)
+			return NEW GhostObjectManagerDummy;
+		return NEW W3DGhostObjectManager;
+	}
 
 };

GeneralsMD/Code/GameEngineDevice/Source/W3DDevice/GameLogic/W3DGhostObject.cpp

@@ -157,7 +157,7 @@ void W3DRenderObjectSnapshot::update(RenderObjClass *robj, DrawableInfo *drawInf
 // ------------------------------------------------------------------------------------------------
 Bool W3DRenderObjectSnapshot::addToScene()
 {
-	if (W3DDisplay::m_3DScene != nullptr && !m_robj->Is_In_Scene())
+	if (!m_robj->Is_In_Scene())
 	{
 		W3DDisplay::m_3DScene->Add_Render_Object(m_robj);
 		return true;