perf(heighmap): Create light list iterator on the stack instead of the heap in BaseHeightMapRenderObjClass::getStaticDiffuse()

Author: Mauller

Core/GameEngineDevice/Source/W3DDevice/GameClient/BaseHeightMap.cpp

@@ -2127,12 +2127,9 @@ Int BaseHeightMapRenderObjClass::getStaticDiffuse(Int x, Int y)
 
 	RTS3DScene *pMyScene = (RTS3DScene *)Scene;
 	if (pMyScene) {
-		RefRenderObjListIterator *it = pMyScene->createLightsIterator();
-		doTheLight(&vertex, lightRay, &normalAtTexel, it, 1.0f);
-		if (it) {
-		 pMyScene->destroyLightsIterator(it);
-		 it = nullptr;
-		}
+		RefRenderObjListClass *lightlist = pMyScene->getLightList();
+		RefRenderObjListIterator it(lightlist);
+		doTheLight(&vertex, lightRay, &normalAtTexel, &it, 1.0f);
 	} else {
 		doTheLight(&vertex, lightRay, &normalAtTexel, nullptr, 1.0f);
 	}

Generals/Code/GameEngineDevice/Include/W3DDevice/GameClient/W3DScene.h

@@ -91,6 +91,7 @@ class RTS3DScene : public SimpleSceneClass, public SubsystemInterface
 	W3DDynamicLight *getADynamicLight();
 	void setGlobalLight(LightClass *pLight,Int lightIndex=0);
 	LightEnvironmentClass &getDefaultLightEnv() {return m_defaultLightEnv;}
+	RefRenderObjListClass* getLightList() { return &LightList; }
 
 	virtual void init() override {}
 	virtual void update() override {}

GeneralsMD/Code/GameEngineDevice/Include/W3DDevice/GameClient/W3DScene.h

@@ -91,6 +91,7 @@ class RTS3DScene : public SimpleSceneClass, public SubsystemInterface
 	W3DDynamicLight *getADynamicLight();
 	void setGlobalLight(LightClass *pLight,Int lightIndex=0);
 	LightEnvironmentClass &getDefaultLightEnv() {return m_defaultLightEnv;}
+	RefRenderObjListClass* getLightList() { return &LightList; }
 
 	virtual void init() override {}
 	virtual void update() override {}