Skip to content

feat(gui): Add replay dates to replay list in Replay Menu #2255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xezon merged 9 commits into from
Feb 8, 2026
Merged

feat(gui): Add replay dates to replay list in Replay Menu #2255

Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a731002
feat(gui): Show date instead of time for listed replays.
Caball009 Feb 4, 2026
df203b1
Changed date to time + date.
Caball009 Feb 4, 2026
b0ed4b5
Switched the column widths.
Caball009 Feb 8, 2026
53e0ad6
Added column width size before swap.
Caball009 Feb 8, 2026
c2fc3ff
Removed assertion and added column count check before swapping.
Caball009 Feb 8, 2026
697c5d4
Improved TSH comment.
Caball009 Feb 8, 2026
c9d485d
Added TSH comment.
Caball009 Feb 8, 2026
c21a2c0
Replicated in Generals.
Caball009 Feb 8, 2026
f0f4ca9
Fixed typo.
Caball009 Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/ReplayMenu.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,9 +290,8 @@ void PopulateReplayFileListbox(GameWindow *listbox)
// name
UnicodeString replayNameToShow = createReplayName(asciistr);

UnicodeString displayTimeBuffer = getUnicodeTimeBuffer(header.timeVal);

//displayTimeBuffer.format( L"%ls", timeBuffer);
UnicodeString displayDateTimeBuffer;
displayDateTimeBuffer.format(L"%s %s", getUnicodeTimeBuffer(header.timeVal).str(), getUnicodeDateBuffer(header.timeVal).str());
Comment thread
Caball009 marked this conversation as resolved.

// version (no-op)

Expand Down Expand Up @@ -353,7 +352,7 @@ void PopulateReplayFileListbox(GameWindow *listbox)

const Int insertionIndex = GadgetListBoxAddEntryText(listbox, replayNameToShow, color, -1, 0);
DEBUG_ASSERTCRASH(insertionIndex >= 0, ("Expects valid index"));
GadgetListBoxAddEntryText(listbox, displayTimeBuffer, color, insertionIndex, 1);
GadgetListBoxAddEntryText(listbox, displayDateTimeBuffer, color, insertionIndex, 1);
GadgetListBoxAddEntryText(listbox, header.versionString, color, insertionIndex, 2);
GadgetListBoxAddEntryText(listbox, mapStr, mapColor, insertionIndex, 3);

Expand Down Expand Up @@ -388,6 +387,16 @@ void ReplayMenuInit( WindowLayout *layout, void *userData )
buttonDelete = TheWindowManager->winGetWindowFromId( parentReplayMenu, buttonDeleteID );
buttonCopy = TheWindowManager->winGetWindowFromId( parentReplayMenu, buttonCopyID );

#if ENABLE_GUI_HACKS
// TheSuperHackers @tweak Caball009 07/02/2025 Switch the column width for the time / date with the column width for the version.
Comment thread
xezon marked this conversation as resolved.
Outdated
ListboxData* list = static_cast<ListboxData*>(listboxReplayFiles->winGetUserData());
DEBUG_ASSERTCRASH(list && list->columns >= 3 && list->columnWidth[1] < list->columnWidth[2],
Comment thread
Caball009 marked this conversation as resolved.
Outdated
("Original replay window is expected to have at least 3 columns, and the second column width smaller than the third"));

if (list->columnWidth[1] < list->columnWidth[2])
std::swap(list->columnWidth[1], list->columnWidth[2]);
Comment thread
xezon marked this conversation as resolved.
#endif

//Load the listbox shiznit
GadgetListBoxReset(listboxReplayFiles);
PopulateReplayFileListbox(listboxReplayFiles);
Expand Down
Loading