build: Fix compile error in Smudge.h with docker-build#2701
Open
ucosty wants to merge 1 commit into
Open
Conversation
… docker-build This short fix gets the build working again, and should close out issue TheSuperHackers#2674
4 tasks
|
| Filename | Overview |
|---|---|
| Core/GameEngine/Include/GameClient/Smudge.h | Adds missing direct include of Common/STLTypedefs.h, which provides std::hash_map used on line 81 in SmudgeSet::SmudgeIdToPtrMap; previously relied on transitive inclusion that was not guaranteed. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Smudge.h] -->|now explicitly includes| B[Common/STLTypedefs.h]
B --> C[Utility/hash_map_adapter.h]
C --> D[std::hash_map available]
A --> E[SmudgeSet::SmudgeIdToPtrMap\ntypedef std::hash_map<...>]
D -->|resolves| E
A --> F[WW3D2/dllist.h]
A --> G[WWMath/vector2.h]
A --> H[WWMath/vector3.h]
style B fill:#90EE90
style D fill:#90EE90
Reviews (1): Last reviewed commit: "Issue #2674: Resolve build failure exper..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This short fix gets the build working again, and should close out issue #2674