[pull] main from bootc-dev:main#140
Merged
Merged
Conversation
This is a safer API, but this is specifically prep for using varlink. Assisted-by: OpenCode (Claude Opus 4) Signed-off-by: Colin Walters <walters@verbum.org>
ZFS filesystems report their mount source as a dataset name (e.g. 'rpool/root') rather than a block device path. Passing this to lsblk causes it to fail with 'not a block device', breaking bootc status and bootc upgrade on ZFS-rooted systems. Add list_dev_for_zfs_dataset() which extracts the pool name and queries 'zpool list -H -v -P <pool>' to find the underlying block device path, then delegates to list_dev() as normal. Detect ZFS sources in list_dev_by_dir() via fstype=='zfs' or by a non-absolute path containing '/' (dataset name form). Fixes: #1240 Signed-off-by: James Reilly <jreilly1821@gmail.com> Assisted-by: GitHub Copilot (claude-sonnet-4-6)
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
Signed-off-by: Wolter Eldering <wolter@eldering.online>
This got bumped recently so the old version is no longer available. Signed-off-by: John Eckersberg <jeckersb@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )