Skip to content

Improve error messages when claiming a managed gateway#7603

Merged
PavelJankoski merged 3 commits into
v3.34from
issue/claim-error-messages
May 6, 2025
Merged

Improve error messages when claiming a managed gateway#7603
PavelJankoski merged 3 commits into
v3.34from
issue/claim-error-messages

Conversation

@PavelJankoski

Copy link
Copy Markdown
Contributor

Summary

References #7547

Changes

  • Improved the error messages when claiming a managed gateway based on gRPC error status code.

Testing

Steps
  1. Login to console.
  2. Go to Gateways.
  3. Click on Register gateway.
  4. Follow the steps in the last comment of the issue.
Results

NotFound:
image

FailedPrecondition:
image

PermissionDenied:
image

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@PavelJankoski PavelJankoski self-assigned this Apr 25, 2025
@PavelJankoski PavelJankoski requested a review from a team as a code owner April 25, 2025 14:06
@github-actions github-actions Bot added the ui/web This is related to a web interface label Apr 25, 2025
Comment thread pkg/webui/console/containers/gateway-onboarding-form/index.js Outdated
Comment thread pkg/webui/console/containers/gateway-onboarding-form/index.js Outdated
@PavelJankoski PavelJankoski requested a review from ryaplots April 29, 2025 16:11
@PavelJankoski PavelJankoski force-pushed the issue/claim-error-messages branch from eaffe38 to d5996a2 Compare April 29, 2025 16:14
@PavelJankoski PavelJankoski force-pushed the issue/claim-error-messages branch from d5996a2 to f253cf7 Compare April 29, 2025 16:14
@PavelJankoski PavelJankoski merged commit 5001068 into v3.34 May 6, 2025
12 of 13 checks passed
@PavelJankoski PavelJankoski deleted the issue/claim-error-messages branch May 6, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui/web This is related to a web interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants