Fix searching users in user management#7625
Merged
Merged
Conversation
ryaplots
requested changes
May 20, 2025
ryaplots
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
References https://github.com/TheThingsIndustries/lorawan-stack-support/issues/1242#issuecomment-2858608417
Not saving the reference of
tabsWithInvitationswithuseMemocaused fetching data on every character change in the search bar.Changes
tabsWithInvitationsinuseMemoinUsersTable.Testing
Steps
Follow steps described in the referenced comment (in the Summary section).
Results
The search should work fine.
Checklist
README.mdfor the chosen target branch.CHANGELOG.md.CONTRIBUTING.md, there are no fixup commits left.