Skip to content

Fix searching users in user management#7625

Merged
PavelJankoski merged 1 commit into
v3.34from
fix/users-fetch-table
May 20, 2025
Merged

Fix searching users in user management#7625
PavelJankoski merged 1 commit into
v3.34from
fix/users-fetch-table

Conversation

@PavelJankoski
Copy link
Copy Markdown
Contributor

Summary

References https://github.com/TheThingsIndustries/lorawan-stack-support/issues/1242#issuecomment-2858608417

Not saving the reference of tabsWithInvitations with useMemo caused fetching data on every character change in the search bar.

Changes

  • Wrapped tabsWithInvitations in useMemo in UsersTable.

Testing

Steps

Follow steps described in the referenced comment (in the Summary section).

Results

The search should work fine.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@PavelJankoski PavelJankoski requested a review from ryaplots May 19, 2025 22:06
@PavelJankoski PavelJankoski self-assigned this May 19, 2025
@PavelJankoski PavelJankoski requested a review from a team as a code owner May 19, 2025 22:06
@PavelJankoski PavelJankoski added the bug Something isn't working label May 19, 2025
@github-actions github-actions Bot added the ui/web This is related to a web interface label May 19, 2025
@PavelJankoski PavelJankoski changed the title console: Fix user management fetch table Fix searching users in user management May 19, 2025
Comment thread pkg/webui/console/containers/users-table/index.js
@PavelJankoski PavelJankoski requested a review from ryaplots May 20, 2025 10:29
@PavelJankoski PavelJankoski merged commit 4589c86 into v3.34 May 20, 2025
13 checks passed
@PavelJankoski PavelJankoski deleted the fix/users-fetch-table branch May 20, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ui/web This is related to a web interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants