Reduce TTIGW protocol disconnects based on missed pongs#7733
Merged
Conversation
This is now aligned with the settings of the Gateway Controller. The Gateway Controller reports far less disconnects during the same time period than The Things Stack, indicating that The Things Stack marks the gateway connection disconnected unnecessarily, possibly during short Cellular or WiFi outages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This reduces the number of TTIGW protocol disconnections because of not receiving pong answers to pings in time.
The ping timeout and interval are now aligned with the Gateway Controller. The Gateway Controller marks far less gateway connections as disconnected for the same gateway during the same time frame, suggesting that The Things Stack unnecessarily marks gateway connections gone.
Changes
Testing
We'll observe this in operational metrics.
Checklist
README.mdfor the chosen target branch.CHANGELOG.md.CONTRIBUTING.md, there are no fixup commits left.