refactor: remove redundant variable declarations in for loops#7761
Merged
Conversation
Contributor
Author
|
There seem to be a lot of changes. Do I need to split them into multiple PRs to submit? |
johanstokking
left a comment
Member
There was a problem hiding this comment.
Thanks, I hope you did this with a regex replace 😁
One small comment.
nicholaspcr
approved these changes
Nov 20, 2025
nicholaspcr
left a comment
Contributor
There was a problem hiding this comment.
This looks really nice, appreciate the contribution.
Member
|
Thanks @efcking. Please also run: $ make tools/bin/mage
$ tools/bin/mage go:fmt |
ryaplots
approved these changes
Nov 24, 2025
Signed-off-by: efcking <efcking@outlook.com>
Contributor
Author
Sorry for handling this so late.
I have executed these two commands, merged the commits, and pushed them. So need to review it again. @johanstokking @nicholaspcr @ryaplots Thank you. |
johanstokking
approved these changes
Nov 26, 2025
Member
|
Thanks @efcking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
The new version of Go has been optimized, and variables do not need to be reassigned.
For more info: https://tip.golang.org/wiki/LoopvarExperiment#does-this-mean-i-dont-have-to-write-x--x-in-my-loops-anymore
Changes
Testing
Steps
...
Results
Regressions
...
Notes for Reviewers
...
Checklist
README.mdfor the chosen target branch.CHANGELOG.md.CONTRIBUTING.md, there are no fixup commits left.