Skip to content

Add HSTS headers to the web server#7770

Merged
vlasebian merged 3 commits into
v3.35from
feat/hsts-headers
Nov 27, 2025
Merged

Add HSTS headers to the web server#7770
vlasebian merged 3 commits into
v3.35from
feat/hsts-headers

Conversation

@vlasebian
Copy link
Copy Markdown
Contributor

Summary

Add HSTS headers to the web server.

Changes

  • Implement web middleware for HSTS header
  • Add the middleware to the web server

Testing

Steps

Unit testing.

Results
Regressions

None.

Notes for Reviewers

I did not make the header values configurable. The values are standard and adding the HSTS fields to the configuration does not add any benefit IMO, but I don't have any strong opinion against it either.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@vlasebian vlasebian self-assigned this Nov 26, 2025
@vlasebian vlasebian requested review from a team as code owners November 26, 2025 12:05
Copy link
Copy Markdown
Member

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vlasebian vlasebian merged commit 5306794 into v3.35 Nov 27, 2025
15 of 17 checks passed
@vlasebian vlasebian deleted the feat/hsts-headers branch November 27, 2025 11:15
happyRip pushed a commit that referenced this pull request Nov 27, 2025
* all: Implement HSTS headers

* dev: Update changelog

* dev: Linting issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants