Try fix sideload subtitles external for android#4797
Open
pigeonmal wants to merge 2 commits into
Open
Conversation
github-project-automation
Bot
moved this to To Triage
in React Native Video - Public Roadmap
mcay23
added a commit
to Hound-Media-Server/hound-app
that referenced
this pull request
May 3, 2026
apply patches from TheWidlarzGroup/react-native-video#4797 to get exoplayer external subtitles to work on android regression: embedded subs padding doesn't match external subs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We can't use external subtitles in android
Motivation
#4614
Changes
I used the source code of media3 1.4.1 like react native video use.
This is a adapted code from my original fork, I didn't tested if there is a build error, I code in plain text editor.