fix(android): controls always show in fullscreen #4813
Conversation
github-project-automation
Bot
moved this to To Triage
in React Native Video - Public Roadmap
|
Thanks for the PR! |
|
@robertert could this be merged? |
| private void updateControllerConfig() { | ||
| if (exoPlayerView == null) return; | ||
|
|
||
| // Extra configuration for proper touch handling |
There was a problem hiding this comment.
Could you delete this comment?
| private void refreshControlsStyles() { | ||
| if (exoPlayerView == null || player == null || !controls) return; | ||
| if (exoPlayerView == null || player == null) return; | ||
| // Always update controller visibility to ensure it matches current state |
There was a problem hiding this comment.
Could you delete this comment?
| if (exoPlayerView != null) { | ||
| exoPlayerView.showController(); | ||
| } |
| boolean shouldShowControls = controls || isFullscreen; | ||
| if (shouldShowControls) { | ||
| updateControllerConfig(); |
There was a problem hiding this comment.
What about the configuration we deleted?
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where player controls were not visible in fullscreen mode when controls={false} on Android (version >= 6.16.0). The fix ensures controls are always shown in fullscreen mode regardless of the controls prop value, which aligns with the documented behavior.
Changes:
- Updated controller visibility logic to use
controls || isFullscreeninstead ofcontrols && !controlsConfig.getHideFullscreen() - Refactored and simplified controller visibility management by removing redundant code
- Added explicit controller show/hide calls when entering/exiting fullscreen mode
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@robertert @moskalakamil could we see this merged at some point? |
|
Waiting for this |
|
@robertert @moskalakamil any chance to get this merged and in an release soon? |
|
merged #4907 |
github-project-automation
Bot
moved this from To Triage
to Done
in React Native Video - Public Roadmap
Fixes: #4751
Resolves an issue where player controls were not visible in Fullscreen mode when controls={false} on Android
Changes: