fix(android): controls always show in fullscreen#4907
Conversation
|
I'm open to closing this issue if @robertert's PR #4813 moves forward There are failing checks but that seems like a pre-existing issue on the v6 branch |
|
Heads up for reviewers: the red CI is unrelated to this change. The job fails at Last green Build Android on cc @moskalakamil — you approved #4813; this PR cherry-picks that commit (authorship preserved) and adds a second commit addressing your review nits. |
There was a problem hiding this comment.
Pull request overview
This PR fixes an Android regression where playback controls were not shown in fullscreen when controls={false}, aligning behavior with the documented expectation that fullscreen mode always shows controls.
Changes:
- Make controller enablement depend on
isFullscreen(controls enabled in fullscreen even ifcontrols=false). - Ensure controller visibility refresh runs in fullscreen transitions and no longer bails early when
controlsis false. - Simplify controller configuration/visibility logic around fullscreen enter/exit.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3b186f1
into
TheWidlarzGroup:support/6.x.x
Fixes #4734
Closes #4751
Summary
This is a rebase of the stale PR #4813 by @robertert (preserved as the first commit, original authorship intact), with the second commit addressing the review feedback from @moskalakamil:
shouldShowControlsboolean inupdateControllerVisibilityupdateControllerConfig()+exoPlayerView.showController()on fullscreen entry withrefreshControlsStyles(), which (after the first commit removes the!controlsguard) refreshes visibility unconditionally