Skip to content

Commit 4f8b22e

Browse files
committed
resolved comments
1 parent cdaed4a commit 4f8b22e

1 file changed

Lines changed: 9 additions & 8 deletions

File tree

internal/pkg/handler/update.go

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -41,17 +41,18 @@ func (r ResourceUpdatedHandler) Handle() error {
4141
func (r ResourceUpdatedHandler) GetConfig() (common.Config, string) {
4242
var oldSHAData string
4343
var config common.Config
44-
if _, ok := r.Resource.(*v1.ConfigMap); ok {
44+
switch res := r.Resource.(type) {
45+
case *v1.ConfigMap:
4546
oldSHAData = util.GetSHAfromConfigmap(r.OldResource.(*v1.ConfigMap))
46-
config = common.GetConfigmapConfig(r.Resource.(*v1.ConfigMap))
47-
} else if _, ok := r.Resource.(*v1.Secret); ok {
47+
config = common.GetConfigmapConfig(res)
48+
case *v1.Secret:
4849
oldSHAData = util.GetSHAfromSecret(r.OldResource.(*v1.Secret).Data)
49-
config = common.GetSecretConfig(r.Resource.(*v1.Secret))
50-
} else if _, ok := r.Resource.(*csiv1.SecretProviderClassPodStatus); ok {
50+
config = common.GetSecretConfig(res)
51+
case *csiv1.SecretProviderClassPodStatus:
5152
oldSHAData = util.GetSHAfromSecretProviderClassPodStatus(r.OldResource.(*csiv1.SecretProviderClassPodStatus).Status)
52-
config = common.GetSecretProviderClassPodStatusConfig(r.Resource.(*csiv1.SecretProviderClassPodStatus))
53-
} else {
54-
logrus.Warnf("Invalid resource: Resource should be 'Secret' or 'Configmap' but found, %v", r.Resource)
53+
config = common.GetSecretProviderClassPodStatusConfig(res)
54+
default:
55+
logrus.Warnf("Invalid resource: Resource should be 'Secret', 'Configmap' or 'SecretProviderClassPodStatus' but found, %v", r.Resource)
5556
}
5657
return config, oldSHAData
5758
}

0 commit comments

Comments
 (0)