chore(release): add win fallback and node24#1363
Conversation
📝 WalkthroughWalkthroughGitHub Actions across three workflow files are upgraded from v4 to v6 with added Node 24 configuration. Release process documentation is updated with platform-specific guidance for macOS/Linux and Windows maintainers. A new Node.js launcher script replaces the bash invocation for release automation with Windows platform detection. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/release-flow.md (1)
104-114: Minor: Consider varying sentence structure per static analysis hint.The static analysis tool flagged three successive sentences starting with "Confirm" (steps 3, 4, and 5). This is purely a style suggestion and doesn't affect clarity.
💅 Optional wording variation
-4. Confirm `origin/main` can be fast-forwarded to the reviewed release commit. +4. Verify that `origin/main` can be fast-forwarded to the reviewed release commit.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/release-flow.md` around lines 104 - 114, The three consecutive lines beginning with "Confirm" (steps 3–5) should be reworded to vary sentence openings for static analysis; update the step wording around the git checks that use "git merge-base --is-ancestor <TARGET_SHA> origin/dev" and "git merge-base --is-ancestor origin/main <TARGET_SHA>" so they use different verbs (e.g., "Verify the release commit exists on origin/dev", "Ensure origin/main can be fast-forwarded to the reviewed release commit", "Check ...") while keeping the commands and meaning unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@docs/release-flow.md`:
- Around line 104-114: The three consecutive lines beginning with "Confirm"
(steps 3–5) should be reworded to vary sentence openings for static analysis;
update the step wording around the git checks that use "git merge-base
--is-ancestor <TARGET_SHA> origin/dev" and "git merge-base --is-ancestor
origin/main <TARGET_SHA>" so they use different verbs (e.g., "Verify the release
commit exists on origin/dev", "Ensure origin/main can be fast-forwarded to the
reviewed release commit", "Check ...") while keeping the commands and meaning
unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b8377a93-bf1d-43d6-bc9a-4184e46d08c0
📒 Files selected for processing (9)
.github/workflows/build.yml.github/workflows/prcheck.yml.github/workflows/release.ymlCONTRIBUTING.mdCONTRIBUTING.zh.mddocs/release-flow.mdpackage.jsonscripts/release-fast-forward.mjsscripts/release-fast-forward.sh
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9d2162bf7b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| env: | ||
| FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: 'true' |
There was a problem hiding this comment.
Setting FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 here makes every JavaScript action in this workflow run under Node 24, but this workflow still invokes pnpm/action-setup@v2 a few lines below. The pnpm action’s marketplace page now warns that v2 “has stopped working” with newer Node.js versions, so PR checks/builds/releases can start failing before pnpm install even runs. Please either keep these workflows on the current action runtime or bump pnpm/action-setup to a Node-24-compatible major first.
Useful? React with 👍 / 👎.
| 1. Fetch the latest release refs. | ||
|
|
||
| ```bash | ||
| git fetch origin main dev --prune |
There was a problem hiding this comment.
I checked git fetch -h (git fetch [<options>] [<repository> [<refspec>...]]), so git fetch origin main dev --prune only updates the main and dev refspecs. The very next step resolves origin/release/v…^{commit}, which will be missing in a fresh clone unless that release branch was already fetched locally, so the new Windows/manual fallback can fail at step 2 before any ancestry checks run. Either fetch the release/* ref here or rewrite step 2 around a ref that step 1 guarantees is present.
Useful? React with 👍 / 👎.
1 participant
Summary by CodeRabbit
Chores
Documentation