-
Notifications
You must be signed in to change notification settings - Fork 648
feat(session): persist sidebar group mode preference #1434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,6 +45,9 @@ export interface SessionGroup { | |
|
|
||
| export type GroupMode = 'time' | 'project' | ||
|
|
||
| const SIDEBAR_GROUP_MODE_KEY = 'sidebar_group_mode' | ||
| const DEFAULT_GROUP_MODE: GroupMode = 'project' | ||
|
|
||
| // --- Helper Functions --- | ||
|
|
||
| function mapSessionStatus(status: string): UISessionStatus { | ||
|
|
@@ -133,7 +136,7 @@ function groupByProject(sessions: UISession[]): SessionGroup[] { | |
| projectMap.get(dir)!.push(session) | ||
| } | ||
| return Array.from(projectMap.entries()).map(([dir, sessions]) => ({ | ||
| label: dir === '__no_project__' ? 'common.project.none' : (dir.split('/').pop() ?? dir), | ||
| label: dir === '__no_project__' ? 'common.project.none' : (dir.split(/[\\/]/).pop() ?? dir), | ||
| labelKey: dir === '__no_project__' ? 'common.project.none' : undefined, | ||
| sessions | ||
| })) | ||
|
|
@@ -159,15 +162,20 @@ function getContentType(format: 'markdown' | 'html' | 'txt' | 'nowledge-mem'): s | |
| export const useSessionStore = defineStore('session', () => { | ||
| const agentSessionPresenter = usePresenter('agentSessionPresenter') | ||
| const tabPresenter = usePresenter('tabPresenter') | ||
| const configPresenter = usePresenter('configPresenter', { safeCall: false }) | ||
| const pageRouter = usePageRouterStore() | ||
| const messageStore = useMessageStore() | ||
| const myWebContentsId = getCurrentWebContentsId() | ||
| let rendererReadyNotified = false | ||
| let groupModeLoadPromise: Promise<void> | null = null | ||
| let groupModeWritePromise: Promise<void> = Promise.resolve() | ||
| let hasLoadedGroupMode = false | ||
| let groupModeUpdateVersion = 0 | ||
|
Comment on lines
+170
to
+173
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Serialize the preference writes so the last toggle wins.
Also applies to: 428-442 🤖 Prompt for AI Agents |
||
|
|
||
| // --- State --- | ||
| const sessions = ref<UISession[]>([]) | ||
| const activeSessionId = ref<string | null>(null) | ||
| const groupMode = ref<GroupMode>('time') | ||
| const groupMode = ref<GroupMode>(DEFAULT_GROUP_MODE) | ||
| const loading = ref(false) | ||
| const error = ref<string | null>(null) | ||
|
|
||
|
|
@@ -179,6 +187,41 @@ export const useSessionStore = defineStore('session', () => { | |
|
|
||
| notifyRendererReady() | ||
|
|
||
| const normalizeGroupMode = (value: unknown): GroupMode => | ||
| value === 'time' || value === 'project' ? value : DEFAULT_GROUP_MODE | ||
|
|
||
| const loadGroupModePreference = async (): Promise<void> => { | ||
| const loadVersion = groupModeUpdateVersion | ||
|
|
||
| try { | ||
| const savedGroupMode = await configPresenter.getSetting<GroupMode>(SIDEBAR_GROUP_MODE_KEY) | ||
| if (groupModeUpdateVersion === loadVersion) { | ||
| groupMode.value = normalizeGroupMode(savedGroupMode) | ||
| } | ||
| } catch (error) { | ||
| if (groupModeUpdateVersion === loadVersion) { | ||
| groupMode.value = DEFAULT_GROUP_MODE | ||
| } | ||
| console.warn('[sessionStore] Failed to load sidebar group mode:', error) | ||
|
Comment on lines
+193
to
+205
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These rollback/error paths don't match the real
Also applies to: 434-445 🤖 Prompt for AI Agents |
||
| } finally { | ||
| hasLoadedGroupMode = true | ||
| } | ||
| } | ||
|
|
||
| const ensureGroupModeLoaded = async (): Promise<void> => { | ||
| if (hasLoadedGroupMode) { | ||
| return | ||
| } | ||
|
|
||
| if (!groupModeLoadPromise) { | ||
| groupModeLoadPromise = loadGroupModePreference().finally(() => { | ||
| groupModeLoadPromise = null | ||
| }) | ||
| } | ||
|
|
||
| await groupModeLoadPromise | ||
| } | ||
|
|
||
| // --- Getters --- | ||
| const activeSession: ComputedRef<UISession | undefined> = computed(() => | ||
| sessions.value.find((s) => s.id === activeSessionId.value) | ||
|
|
@@ -194,6 +237,7 @@ export const useSessionStore = defineStore('session', () => { | |
| loading.value = true | ||
| error.value = null | ||
| try { | ||
| await ensureGroupModeLoaded() | ||
| const webContentsId = getCurrentWebContentsId() | ||
| const previousActiveSessionId = activeSessionId.value | ||
| const [result, activeSession] = await Promise.all([ | ||
|
|
@@ -382,8 +426,26 @@ export const useSessionStore = defineStore('session', () => { | |
| } | ||
| } | ||
|
|
||
| function toggleGroupMode(): void { | ||
| groupMode.value = groupMode.value === 'time' ? 'project' : 'time' | ||
| async function toggleGroupMode(): Promise<void> { | ||
| const previousMode = groupMode.value | ||
| groupMode.value = previousMode === 'time' ? 'project' : 'time' | ||
| const localVersion = ++groupModeUpdateVersion | ||
|
|
||
| groupModeWritePromise = groupModeWritePromise.then(async () => { | ||
| try { | ||
| await configPresenter.setSetting(SIDEBAR_GROUP_MODE_KEY, groupMode.value) | ||
| if (localVersion !== groupModeUpdateVersion) { | ||
| return | ||
| } | ||
| } catch (error) { | ||
| if (localVersion === groupModeUpdateVersion) { | ||
| groupMode.value = previousMode | ||
| } | ||
| console.warn('[sessionStore] Failed to persist sidebar group mode:', error) | ||
| } | ||
| }) | ||
|
|
||
| await groupModeWritePromise | ||
| } | ||
|
|
||
| function getPinnedSessions(agentId: string | null): UISession[] { | ||
|
|
@@ -438,6 +500,7 @@ export const useSessionStore = defineStore('session', () => { | |
| } | ||
| }) | ||
| registerStoreCleanup(cleanupIpcBindings) | ||
| void ensureGroupModeLoaded() | ||
|
|
||
| return { | ||
| sessions, | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.