-
Notifications
You must be signed in to change notification settings - Fork 647
feat: issue #1439 #1441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: issue #1439 #1441
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Sidebar And Workspace Shortcuts | ||
|
|
||
| ## User Need | ||
|
|
||
| Laptop users need faster access to more chat space without reaching for the mouse. DeepChat should provide keyboard shortcuts to toggle the left sidebar and the right workspace panel from the main chat window. | ||
|
|
||
| ## Defaults | ||
|
|
||
| - `ToggleSidebar`: `CommandOrControl+B` | ||
| - `ToggleWorkspace`: `CommandOrControl+J` | ||
|
|
||
| ## Acceptance Criteria | ||
|
|
||
| - Both shortcuts are registered through the existing shortcut settings flow. | ||
| - Both shortcuts appear in the settings shortcut page and can be customized. | ||
| - `ToggleSidebar` toggles the main chat sidebar collapsed state. | ||
| - `ToggleWorkspace` toggles the workspace side panel for the active chat session only. | ||
| - Shortcut events are delivered only to the currently focused DeepChat chat window. | ||
| - Existing sidebar and workspace buttons keep working without behavior changes. | ||
|
|
||
| ## Non-Goals | ||
|
|
||
| - No persistence change for sidebar collapsed state. | ||
| - No new buttons, menu items, or layout redesign. | ||
| - No localization sweep for every existing locale in this increment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import { defineStore } from 'pinia' | ||
| import { ref } from 'vue' | ||
|
|
||
| export const useSidebarStore = defineStore('sidebar', () => { | ||
| const collapsed = ref(false) | ||
|
|
||
| const toggleSidebar = () => { | ||
| collapsed.value = !collapsed.value | ||
| } | ||
|
|
||
| const setCollapsed = (value: boolean) => { | ||
| collapsed.value = value | ||
| } | ||
|
|
||
| return { | ||
| collapsed, | ||
| toggleSidebar, | ||
| setCollapsed | ||
| } | ||
| }) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restrict shortcut dispatch to chat window only.
At Line 73 and Line 85, dispatch currently targets any focused window. If the settings window is focused,
TOGGLE_SIDEBAR/TOGGLE_WORKSPACEare sent to the wrong renderer context.💡 Suggested fix
if (this.shortcutKeys.ToggleSidebar) { globalShortcut.register(this.shortcutKeys.ToggleSidebar, () => { const focusedWindow = presenter.windowPresenter.getFocusedWindow() - if (focusedWindow?.isFocused()) { - void presenter.windowPresenter.sendToWebContents( - focusedWindow.webContents.id, - SHORTCUT_EVENTS.TOGGLE_SIDEBAR - ) - } + const settingsWindowId = presenter.windowPresenter.getSettingsWindowId() + if (!focusedWindow?.isFocused() || focusedWindow.id === settingsWindowId) return + void presenter.windowPresenter.sendToWebContents( + focusedWindow.webContents.id, + SHORTCUT_EVENTS.TOGGLE_SIDEBAR + ) }) } if (this.shortcutKeys.ToggleWorkspace) { globalShortcut.register(this.shortcutKeys.ToggleWorkspace, () => { const focusedWindow = presenter.windowPresenter.getFocusedWindow() - if (focusedWindow?.isFocused()) { - void presenter.windowPresenter.sendToWebContents( - focusedWindow.webContents.id, - SHORTCUT_EVENTS.TOGGLE_WORKSPACE - ) - } + const settingsWindowId = presenter.windowPresenter.getSettingsWindowId() + if (!focusedWindow?.isFocused() || focusedWindow.id === settingsWindowId) return + void presenter.windowPresenter.sendToWebContents( + focusedWindow.webContents.id, + SHORTCUT_EVENTS.TOGGLE_WORKSPACE + ) }) }🤖 Prompt for AI Agents