fix(watch): meta version detection

Originally the handshake protocol-version check used && instead of || which would only reject when
both major and minor version were different, so a 3.0 meta would work with a 2.0 watch.

The fix just stops checking the minor version in the handshake so the minor version can be bumped to
indicate new fields were added to the end of messages, without breaking compatibility with older
Watch versions that should just ignore those fields.

Author: iamjoemccormick

watch/internal/metadata/manager.go

@@ -301,7 +301,7 @@ func (m *Manager) handleV2Connection(conn net.Conn, connMutex *sync.Mutex, cance
 	handshakeResp := &HandshakeResponse{}
 	if !handler.recv(handshakeResp) {
 		return
-	} else if handshakeResp.Major != m.eventVersion.major && handshakeResp.Minor != m.eventVersion.minor {
+	} else if handshakeResp.Major != m.eventVersion.major {
 		m.log.Error("unsupported metadata event protocol detected",
 			zap.String("metaProtocolVersion", fmt.Sprintf("%d.%d", handshakeResp.Major, handshakeResp.Minor)),
 			zap.String("watchProtocolVersion", fmt.Sprintf("%d.%d", m.eventVersion.major, m.eventVersion.minor)))