Swartzn/feat/sort by archival placement hints#287
Closed
swartzn wants to merge 2 commits into
Closed
Conversation
…rting Add support for JobRequest SortValues. - Generically allows RST clients to optionally provide an order string slice to sort job requests. Add support for s3 storage class placement hints. - Supports string, integer and float s3 metadata value types. - Includes unit tests Unify rst.GetRemotePathInfo return values into RemotePathInfo type.
Add warning message when builder's job request buffer exceeds memory utilization threshold.
Member
|
For now this was replaced by #312 which adds support for integrating with non-S3 bulk restore APIs. It may be useful to add support for something like sorting by archival placement hints, but we'll defer further work until we have a reason to revisit this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires ThinkParQ/protobuf#65
What does this PR do / why do we need it?
Required for all PRs.
jobrequest.SortValuesso builder jobs can stream requests in a deterministic order. For now, this just supports the changes needed for s3 tape archives.Related Issue(s)
Required when applicable.
Where should the reviewer(s) start reviewing this?
Only required for larger PRs when this may not be immediately obvious.
Are there any specific topics we should discuss before merging?
Not required.
What are the next steps after this PR?
Not required.
Checklist before merging:
Required for all PRs.
When creating a PR these are items to keep in mind that cannot be checked by GitHub actions:
For more details refer to the Go coding standards and the pull request process.