Skip to content

fix: resolve welcome template rendering and new tab button duplication bugs#139

Merged
ThisIs-Developer merged 3 commits into
mainfrom
fix-remediation-welcome-tabbar
May 31, 2026
Merged

fix: resolve welcome template rendering and new tab button duplication bugs#139
ThisIs-Developer merged 3 commits into
mainfrom
fix-remediation-welcome-tabbar

Conversation

@ThisIs-Developer

Copy link
Copy Markdown
Owner

This Pull Request introduces critical production bug fixes to resolve BUG-001 (Welcome Template Missing) and BUG-002 (New Tab Button Duplication) inside the Markdown Viewer application.

Key Changes:

  • BUG-001 Resolved (Synchronous Welcome Template): Inlined the full default welcome markdown document into a <script type="text/markdown" id="default-markdown"> element inside index.html. Refactored script.js to retrieve this content synchronously using textContent.trim(), completely eliminating the asynchronous fetch race condition, FOUC, and empty startup pages.
  • BUG-002 Resolved (Reused New Tab Button): Refactored renderTabBar() to query .tab-bar for an existing .tab-new-btn element before creating a new one. If present, it is reused, preventing duplication and duplicate listener attachments during tab resets, duplication, renames, and deletions.
  • Desktop App Synchronization: Programmatically synchronized all fixes using node prepare.js inside desktop-app/ to ensure complete offline-first parity.

Copilot AI review requested due to automatic review settings May 31, 2026 19:13
@vercel

vercel Bot commented May 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
markdown-viwer Ready Ready Preview, Comment May 31, 2026 7:13pm

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@ThisIs-Developer ThisIs-Developer merged commit 80e14ca into main May 31, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants