Skip to content

fix: resolve welcome template rendering and new tab button duplication bugs #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThisIs-Developer merged 3 commits into from
May 31, 2026
Merged

fix: resolve welcome template rendering and new tab button duplication bugs #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64adc52
fix: resolve welcome template first-run missing and new tab button du…
ThisIs-Developer May 31, 2026
fb90e50
fix: resolve empty welcome template issue via template content textCo…
ThisIs-Developer May 31, 2026
fca498f
fix: use script text/markdown tag to preserve raw HTML tags inside de…
ThisIs-Developer May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions desktop-app/resources/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -854,7 +854,7 @@ <h3 class="modal-section-title">Open-source credits</h3>
</div>
</div>

<template id="default-markdown">---
<script type="text/markdown" id="default-markdown">---
title: Welcome to Markdown Viewer
description: A GitHub-style Markdown renderer with live preview, math, diagrams, and export support.
author: ThisIs-Developer
Expand Down Expand Up @@ -1021,7 +1021,7 @@ <h3 class="modal-section-title">Open-source credits</h3>
## 🛡️ Security Note

This is a fully client-side application. Your content never leaves your browser and stays secure on your device.
</template>
</script>

<script src="/libs/bootstrap.bundle.min.js" integrity="sha384-C6RzsynM9kWDrMNeT87bh95OGNyZPhcTNXj1NW7RuBCsyN/o0jlpcV8Qyq46cDfL" crossorigin="anonymous"></script>
<script src="/js/neutralino.js"></script>
Expand Down
27 changes: 15 additions & 12 deletions desktop-app/resources/js/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1139,18 +1139,21 @@ document.addEventListener("DOMContentLoaded", function () {
};

// "+ Create" button at end of tab list (placed outside tabList to prevent ARIA child violation)
const newBtn = document.createElement('button');
newBtn.className = 'tab-new-btn';
newBtn.title = 'New Tab (Ctrl+T)';
newBtn.setAttribute('aria-label', 'Open new tab');
newBtn.innerHTML = '<i class="bi bi-plus-lg"></i>';
newBtn.addEventListener('click', function() { newTab(); });

const resetBtn = document.getElementById('tab-reset-btn');
if (resetBtn) {
tabList.parentElement.insertBefore(newBtn, resetBtn);
} else {
tabList.parentElement.appendChild(newBtn);
let newBtn = tabList.parentElement.querySelector('.tab-new-btn');
if (!newBtn) {
newBtn = document.createElement('button');
newBtn.className = 'tab-new-btn';
newBtn.title = 'New Tab (Ctrl+T)';
newBtn.setAttribute('aria-label', 'Open new tab');
newBtn.innerHTML = '<i class="bi bi-plus-lg"></i>';
newBtn.addEventListener('click', function() { newTab(); });

const resetBtn = document.getElementById('tab-reset-btn');
if (resetBtn) {
tabList.parentElement.insertBefore(newBtn, resetBtn);
} else {
tabList.parentElement.appendChild(newBtn);
}
}

// Auto-scroll active tab into view (paint-aligned to prevent forced reflows)
Expand Down
4 changes: 2 additions & 2 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -913,7 +913,7 @@ <h3 class="modal-section-title">Open-source credits</h3>
</div>
</div>

<template id="default-markdown">---
<script type="text/markdown" id="default-markdown">---
title: Welcome to Markdown Viewer
description: A GitHub-style Markdown renderer with live preview, math, diagrams, and export support.
author: ThisIs-Developer
Expand Down Expand Up @@ -1080,7 +1080,7 @@ <h3 class="modal-section-title">Open-source credits</h3>
## 🛡️ Security Note

This is a fully client-side application. Your content never leaves your browser and stays secure on your device.
</template>
</script>

<script src="https://cdnjs.cloudflare.com/ajax/libs/bootstrap/5.3.2/js/bootstrap.bundle.min.js" integrity="sha384-C6RzsynM9kWDrMNeT87bh95OGNyZPhcTNXj1NW7RuBCsyN/o0jlpcV8Qyq46cDfL" crossorigin="anonymous"></script>
<script src="script.js"></script>
Expand Down
27 changes: 15 additions & 12 deletions script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1139,18 +1139,21 @@ document.addEventListener("DOMContentLoaded", function () {
};

// "+ Create" button at end of tab list (placed outside tabList to prevent ARIA child violation)
const newBtn = document.createElement('button');
newBtn.className = 'tab-new-btn';
newBtn.title = 'New Tab (Ctrl+T)';
newBtn.setAttribute('aria-label', 'Open new tab');
newBtn.innerHTML = '<i class="bi bi-plus-lg"></i>';
newBtn.addEventListener('click', function() { newTab(); });

const resetBtn = document.getElementById('tab-reset-btn');
if (resetBtn) {
tabList.parentElement.insertBefore(newBtn, resetBtn);
} else {
tabList.parentElement.appendChild(newBtn);
let newBtn = tabList.parentElement.querySelector('.tab-new-btn');
if (!newBtn) {
newBtn = document.createElement('button');
newBtn.className = 'tab-new-btn';
newBtn.title = 'New Tab (Ctrl+T)';
newBtn.setAttribute('aria-label', 'Open new tab');
newBtn.innerHTML = '<i class="bi bi-plus-lg"></i>';
newBtn.addEventListener('click', function() { newTab(); });

const resetBtn = document.getElementById('tab-reset-btn');
if (resetBtn) {
tabList.parentElement.insertBefore(newBtn, resetBtn);
} else {
tabList.parentElement.appendChild(newBtn);
}
}

// Auto-scroll active tab into view (paint-aligned to prevent forced reflows)
Expand Down
Loading