Skip to content

fix: resolve onboarding welcome template empty content bug (BUG-ONBOARD-001) #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThisIs-Developer merged 1 commit into from
May 31, 2026
Merged

fix: resolve onboarding welcome template empty content bug (BUG-ONBOARD-001) #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion desktop-app/resources/js/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -866,7 +866,15 @@ document.addEventListener("DOMContentLoaded", function () {

// PERF-012: Inlined default template to eliminate network request, FOUC, and layout shifts
const defaultMarkdownTemplate = document.getElementById('default-markdown');
const sampleMarkdown = defaultMarkdownTemplate ? defaultMarkdownTemplate.textContent.trim() : '# Welcome to Markdown Viewer\n\nStart typing your markdown here...';
let templateText = '';
if (defaultMarkdownTemplate) {
if (defaultMarkdownTemplate.content && typeof defaultMarkdownTemplate.content.textContent === 'string') {
templateText = defaultMarkdownTemplate.content.textContent.trim();
} else {
templateText = defaultMarkdownTemplate.textContent ? defaultMarkdownTemplate.textContent.trim() : '';
}
}
const sampleMarkdown = templateText || '# Welcome to Markdown Viewer\n\nStart typing your markdown here...';

if (!markdownEditor.value) {
markdownEditor.value = sampleMarkdown;
Expand Down
10 changes: 9 additions & 1 deletion script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -866,7 +866,15 @@ document.addEventListener("DOMContentLoaded", function () {

// PERF-012: Inlined default template to eliminate network request, FOUC, and layout shifts
const defaultMarkdownTemplate = document.getElementById('default-markdown');
const sampleMarkdown = defaultMarkdownTemplate ? defaultMarkdownTemplate.textContent.trim() : '# Welcome to Markdown Viewer\n\nStart typing your markdown here...';
let templateText = '';
if (defaultMarkdownTemplate) {
if (defaultMarkdownTemplate.content && typeof defaultMarkdownTemplate.content.textContent === 'string') {
templateText = defaultMarkdownTemplate.content.textContent.trim();
} else {
templateText = defaultMarkdownTemplate.textContent ? defaultMarkdownTemplate.textContent.trim() : '';
}
}
const sampleMarkdown = templateText || '# Welcome to Markdown Viewer\n\nStart typing your markdown here...';

if (!markdownEditor.value) {
markdownEditor.value = sampleMarkdown;
Expand Down
Loading