Skip to content

perf: resolve startup forced reflows, debounce resize layout, and optimize touch targets #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThisIs-Developer merged 1 commit into from
Jun 1, 2026
Merged

perf: resolve startup forced reflows, debounce resize layout, and optimize touch targets #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions desktop-app/resources/js/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5073,12 +5073,17 @@ document.addEventListener("DOMContentLoaded", function () {

initTabs();
if (loadGlobalState().syncScrollingEnabled === false) toggleSyncScrolling();
initEditorGeometry();
refreshEditorWidth();
updateMobileStats();
updateFindHighlights();
syncHighlightScroll();

// Defer DOM geometry measurement until after FCP/LCP critical paint path
setTimeout(function() {
initEditorGeometry();
refreshEditorWidth();
scheduleLineNumberUpdate();
}, 100);
Comment on lines +5080 to +5085

// Initialize resizer - Story 1.3
initResizer();
function constrainFloatingPanelPosition() {
Expand All @@ -5105,14 +5110,18 @@ document.addEventListener("DOMContentLoaded", function () {
lastFloatingTop = constrainedTop;
}

let resizeLayoutTimeout = null;
window.addEventListener('resize', () => {
initEditorGeometry();
refreshEditorWidth();
scheduleLineNumberUpdate();
if (window.innerWidth < 1080 && isFrDocked && isFindModalOpen) {
toggleFrDockMode(true);
}
constrainFloatingPanelPosition();
clearTimeout(resizeLayoutTimeout);
resizeLayoutTimeout = setTimeout(function() {
initEditorGeometry();
refreshEditorWidth();
scheduleLineNumberUpdate();
if (window.innerWidth < 1080 && isFrDocked && isFindModalOpen) {
toggleFrDockMode(true);
}
constrainFloatingPanelPosition();
}, 100);
});

// View Mode Button Event Listeners - Story 1.1
Expand Down
40 changes: 40 additions & 0 deletions desktop-app/resources/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1890,6 +1890,46 @@ a:focus {
position: relative;
}

/* Touch Hitbox Expansion for Tab Menu Button */
.tab-menu-btn::before {
content: '';
position: absolute;
top: 50%;
left: 50%;
transform: translate(-50%, -50%);
width: 48px;
height: 48px;
}
Comment on lines +1893 to +1902

/* Touch-optimized styling for coarser pointers (e.g., smartphones & tablets) */
@media (pointer: coarse) {
.tab-bar {
height: 40px !important;
}
.tab-item {
height: 40px !important;
font-size: 14px !important;
padding: 0 10px 0 12px !important;
gap: 8px !important;
}
.tab-new-btn {
width: 32px !important;
height: 32px !important;
font-size: 18px !important;
}
.tab-menu-btn {
width: 30px !important;
height: 30px !important;
font-size: 18px !important;
}
.tab-close-btn {
width: 20px !important;
height: 20px !important;
font-size: 13px !important;
opacity: 0.8 !important;
}
}

.tab-item:hover .tab-menu-btn,
.tab-item.active .tab-menu-btn {
opacity: 0.65;
Expand Down
27 changes: 18 additions & 9 deletions script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5073,12 +5073,17 @@ document.addEventListener("DOMContentLoaded", function () {

initTabs();
if (loadGlobalState().syncScrollingEnabled === false) toggleSyncScrolling();
initEditorGeometry();
refreshEditorWidth();
updateMobileStats();
updateFindHighlights();
syncHighlightScroll();

// Defer DOM geometry measurement until after FCP/LCP critical paint path
setTimeout(function() {
initEditorGeometry();
refreshEditorWidth();
scheduleLineNumberUpdate();
}, 100);
Comment on lines +5080 to +5085

// Initialize resizer - Story 1.3
initResizer();
function constrainFloatingPanelPosition() {
Expand All @@ -5105,14 +5110,18 @@ document.addEventListener("DOMContentLoaded", function () {
lastFloatingTop = constrainedTop;
}

let resizeLayoutTimeout = null;
window.addEventListener('resize', () => {
initEditorGeometry();
refreshEditorWidth();
scheduleLineNumberUpdate();
if (window.innerWidth < 1080 && isFrDocked && isFindModalOpen) {
toggleFrDockMode(true);
}
constrainFloatingPanelPosition();
clearTimeout(resizeLayoutTimeout);
resizeLayoutTimeout = setTimeout(function() {
initEditorGeometry();
refreshEditorWidth();
scheduleLineNumberUpdate();
if (window.innerWidth < 1080 && isFrDocked && isFindModalOpen) {
toggleFrDockMode(true);
}
constrainFloatingPanelPosition();
}, 100);
});

// View Mode Button Event Listeners - Story 1.1
Expand Down
40 changes: 40 additions & 0 deletions styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1890,6 +1890,46 @@ a:focus {
position: relative;
}

/* Touch Hitbox Expansion for Tab Menu Button */
.tab-menu-btn::before {
content: '';
position: absolute;
top: 50%;
left: 50%;
transform: translate(-50%, -50%);
width: 48px;
height: 48px;
}
Comment on lines +1893 to +1902

/* Touch-optimized styling for coarser pointers (e.g., smartphones & tablets) */
@media (pointer: coarse) {
.tab-bar {
height: 40px !important;
}
.tab-item {
height: 40px !important;
font-size: 14px !important;
padding: 0 10px 0 12px !important;
gap: 8px !important;
}
.tab-new-btn {
width: 32px !important;
height: 32px !important;
font-size: 18px !important;
}
.tab-menu-btn {
width: 30px !important;
height: 30px !important;
font-size: 18px !important;
}
.tab-close-btn {
width: 20px !important;
height: 20px !important;
font-size: 13px !important;
opacity: 0.8 !important;
}
}

.tab-item:hover .tab-menu-btn,
.tab-item.active .tab-menu-btn {
opacity: 0.65;
Expand Down
Loading