Remove dropzone banner; make full window the drag-and-drop target#82
Merged
ThisIs-Developer merged 2 commits intomainfrom May 5, 2026
Merged
Conversation
…p overlay and subtle editor hint Agent-Logs-Url: https://github.com/ThisIs-Developer/Markdown-Viewer/sessions/32f3ea84-25cb-422a-8e8f-941055bdd220 Co-authored-by: ThisIs-Developer <109382325+ThisIs-Developer@users.noreply.github.com>
…depth counter desync Agent-Logs-Url: https://github.com/ThisIs-Developer/Markdown-Viewer/sessions/32f3ea84-25cb-422a-8e8f-941055bdd220 Co-authored-by: ThisIs-Developer <109382325+ThisIs-Developer@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
ThisIs-Developer
May 5, 2026 05:38
View session
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ThisIs-Developer
deleted the
copilot/remove-navbar-and-improve-space-management
branch
There was a problem hiding this comment.
Pull request overview
This PR removes the old inline dropzone banner and replaces it with a full-window drag-and-drop experience, keeping the root web app and duplicated Neutralino desktop resources aligned.
Changes:
- Replaced the banner-style dropzone markup with a full-screen drag overlay and an empty-editor drop hint.
- Reworked drag-and-drop handling from dropzone-scoped listeners to document-level file drag listeners with a depth counter.
- Removed now-obsolete dropzone hide logic from file import paths in the desktop wrapper and shared script.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
styles.css |
Replaces dropzone styles with drag overlay/drop hint styling in the web UI. |
script.js |
Switches shared web drag/drop logic to document-level overlay handling. |
index.html |
Removes the old banner and adds overlay/hint markup in the web app. |
desktop-app/resources/styles.css |
Mirrors the shared CSS drag/drop UI changes for the desktop app. |
desktop-app/resources/js/script.js |
Mirrors the shared drag/drop JavaScript changes for the desktop app. |
desktop-app/resources/js/main.js |
Removes obsolete desktop dropzone-hiding code when opening initial files. |
desktop-app/resources/index.html |
Mirrors the shared HTML overlay/hint changes for the desktop app. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| user-select: none; | ||
| } | ||
|
|
||
| .editor-pane:has(#markdown-editor:not(:placeholder-shown)) .drop-hint { |
| user-select: none; | ||
| } | ||
|
|
||
| .editor-pane:has(#markdown-editor:not(:placeholder-shown)) .drop-hint { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dedicated "Drop your Markdown file here" banner between the tab bar and editor wasted vertical space and cluttered the UI. This removes it and makes the entire window the drop surface instead.
Changes
HTML (
index.html,desktop-app/resources/index.html)#dropzonebanner element and its close button#drag-overlay— a full-screen overlay rendered inside.app-container, shown only during active file drags.drop-hintelement inside.editor-pane— subtle static hint visible only when editor is emptyCSS (
styles.css,desktop-app/resources/styles.css).dropzone,.close-btn,.mobile-menu-panel .dropzone, and--dropzone-bgrules#drag-overlaystyles: fixed full-screen semi-transparent backdrop with centered dashed border box and pulse animation.drop-hintstyles: absolutely-positioned bottom-center text, hidden via:placeholder-shownwhen editor has contentJS (
script.js,desktop-app/resources/js/script.js,desktop-app/resources/js/main.js)dragenter/dragover/dragleave/drophandlersdragDepthcounter (incremented ondragenter, decremented ondragleave) to reliably show/hide the overlay across nested DOM elements — bothdragenteranddragleaveguard against non-file drag events to prevent counter desyncdropzone.style.display = "none"calls fromimportMarkdownFileand the Neutralinojs file open handler