fix: improve version handling in update command hints to avoid stale resolutions with go install update (#47)

Author: roblaszczak

internal/selfupdate.go

@@ -240,10 +240,12 @@ func RunUpdate(ctx context.Context, currentVersion string, opts UpdateOptions) e
 			[]string{"upgrade", "tdl"})
 
 	case InstallMethodGoInstall:
-		ref := "latest"
-		if opts.TargetVersion != "" {
-			ref = "v" + strings.TrimPrefix(opts.TargetVersion, "v")
-		}
+		// Pin to the explicit version we just resolved via the GitHub API
+		// rather than letting `go install` resolve "@latest" itself. The Go
+		// module proxy caches "@latest" and can serve a stale version right
+		// after a release, which would silently re-install the current
+		// version and cause the update prompt to loop.
+		ref := "v" + strings.TrimPrefix(targetVersion, "v")
 		return updateViaCommand(ctx, "go", opts, currentVersion, targetVersion,
 			[]string{"install", "github.com/ThreeDotsLabs/cli/tdl@" + ref})
 

internal/update.go

@@ -184,7 +184,7 @@ func showBlockingUpdatePrompt(updateInfo UpdateInfo, currentVersion string) {
 		}
 	}
 
-	hint := updateCommandHint(method)
+	hint := updateCommandHint(method, updateInfo.AvailableVersion)
 	action := "update now"
 	if hint != "" {
 		action = fmt.Sprintf("run %s", SprintCommand(hint))
@@ -225,12 +225,18 @@ func showBlockingUpdatePrompt(updateInfo UpdateInfo, currentVersion string) {
 	os.Exit(0)
 }
 
-func updateCommandHint(method InstallMethod) string {
+func updateCommandHint(method InstallMethod, availableVersion string) string {
 	switch method {
 	case InstallMethodHomebrew:
 		return "brew upgrade tdl"
 	case InstallMethodGoInstall:
-		return "go install github.com/ThreeDotsLabs/cli/tdl@latest"
+		// Pin to the explicit version when we know it so copy-pasting the
+		// hint does not hit a stale "@latest" resolution in the Go proxy.
+		ref := "latest"
+		if availableVersion != "" {
+			ref = "v" + strings.TrimPrefix(availableVersion, "v")
+		}
+		return "go install github.com/ThreeDotsLabs/cli/tdl@" + ref
 	case InstallMethodNix:
 		return "nix profile upgrade --flake github:ThreeDotsLabs/cli"
 	case InstallMethodScoop:

internal/update_test.go

@@ -47,20 +47,24 @@ func TestShouldShowBlockingPrompt(t *testing.T) {
 
 func TestUpdateCommandHint(t *testing.T) {
 	tests := []struct {
-		method   InstallMethod
-		expected string
+		name             string
+		method           InstallMethod
+		availableVersion string
+		expected         string
 	}{
-		{InstallMethodHomebrew, "brew upgrade tdl"},
-		{InstallMethodGoInstall, "go install github.com/ThreeDotsLabs/cli/tdl@latest"},
-		{InstallMethodNix, "nix profile upgrade --flake github:ThreeDotsLabs/cli"},
-		{InstallMethodScoop, "scoop update tdl"},
-		{InstallMethodDirectBinary, ""},
-		{InstallMethodUnknown, ""},
+		{"homebrew", InstallMethodHomebrew, "1.2.0", "brew upgrade tdl"},
+		{"go install with version", InstallMethodGoInstall, "1.2.0", "go install github.com/ThreeDotsLabs/cli/tdl@v1.2.0"},
+		{"go install with v-prefixed version", InstallMethodGoInstall, "v1.2.0", "go install github.com/ThreeDotsLabs/cli/tdl@v1.2.0"},
+		{"go install without version falls back to latest", InstallMethodGoInstall, "", "go install github.com/ThreeDotsLabs/cli/tdl@latest"},
+		{"nix", InstallMethodNix, "1.2.0", "nix profile upgrade --flake github:ThreeDotsLabs/cli"},
+		{"scoop", InstallMethodScoop, "1.2.0", "scoop update tdl"},
+		{"direct binary", InstallMethodDirectBinary, "1.2.0", ""},
+		{"unknown", InstallMethodUnknown, "1.2.0", ""},
 	}
 
 	for _, tt := range tests {
-		t.Run(tt.method.String(), func(t *testing.T) {
-			assert.Equal(t, tt.expected, updateCommandHint(tt.method))
+		t.Run(tt.name, func(t *testing.T) {
+			assert.Equal(t, tt.expected, updateCommandHint(tt.method, tt.availableVersion))
 		})
 	}
 }