[QA] Add Rector for QA (#5)

Author: samsonasik

.github/workflows/ci.yml

@@ -40,5 +40,8 @@ jobs:
           vendor/bin/readme-examples-sync
           git diff --exit-code README.md || (echo "README.md is out of sync with example files. Run 'vendor/bin/readme-examples-sync' and commit the changes." && exit 1)
 
+      - name: Run Rector
+        run: vendor/bin/rector --dry-run
+
       - name: Run PHP CS Fixer
         run: vendor/bin/php-cs-fixer check --diff

composer.json

@@ -15,6 +15,7 @@
     "require-dev": {
         "captainhook/captainhook-phar": "^5.28",
         "ergebnis/composer-normalize": "^2.50",
+        "rector/rector": "^2.3",
         "ruudk/readme-examples-sync-hook": "^2.0"
     },
     "autoload": {

composer.lock

@@ -23,3 +23,8 @@ pre-commit:
             glob: "*.php"
             run: vendor/bin/php-cs-fixer fix --config .php-cs-fixer.php -- {staged_files}
             stage_fixed: true
+
+        rector:
+            glob: "*.php"
+            run: vendor/bin/rector process {staged_files}
+            stage_fixed: true

lefthook.yml

@@ -0,0 +1,11 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+
+return RectorConfig::configure()
+    ->withPaths([
+        __DIR__ . '/src',
+    ])
+    ->withPhpSets();

rector.php

@@ -4,6 +4,7 @@
 
 namespace Ticketswap\PhpCsFixerConfig\Fixer;
 
+use Override;
 use PhpCsFixer\AbstractFixer;
 use PhpCsFixer\FixerDefinition\FixerDefinition;
 use PhpCsFixer\FixerDefinition\FixerDefinitionInterface;
@@ -51,6 +52,7 @@ public function isCandidate(Tokens $tokens) : bool
      *
      * Must run before NoBlankLinesAfterPhpdocFixer.
      */
+    #[Override]
     public function getPriority() : int
     {
         return 1;

src/Fixer/PhpdocAboveAttributeFixer.php

@@ -6,17 +6,14 @@
 
 final readonly class RuleSet
 {
-    public Fixers $customFixers;
     public Rules $rules;
 
     public function __construct(
-        Fixers $customFixers,
+        public Fixers $customFixers,
         Rules $rules,
     ) {
-        $this->customFixers = $customFixers;
-
         $enable = [];
-        foreach ($customFixers->value as $customFixer) {
+        foreach ($this->customFixers->value as $customFixer) {
             $enable[$customFixer->getName()] = true;
         }