Fix the acceptance test slowdown#17
Open
kiwi-josh wants to merge 1 commit into
Open
Conversation
The original now function in backburner calls the now function on the on the Date object itself, whereas this library currently invokes the Date object instead, returning a Date instance that is more costly - especially when called frequently.
Contributor
Author
|
@cmaxwell-eb any chance of getting this PR reviewed? Let me know if you need anything else from me to help this happen 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for this issue: #3
The original now function in backburner calls the now function on the Date object itself, whereas this library currently invokes the Date object instead, returning a Date instance that is more costly - especially when called frequently.