Update this addon to a more modern approach#30
Open
kiwiupover wants to merge 4 commits into
Open
Conversation
kiwiupover
force-pushed
the
update-ember
branch
from
045172a to
25dcccb
Compare
jrjohnson
reviewed
Oct 27, 2021
| */ | ||
| const freezeDateAt = (...args) => { | ||
| trySet(Ember, 'run.backburner._platform.now', () => originalDate()); | ||
| trySet(run, 'backburner._platform.now', originalDate.now()); |
There was a problem hiding this comment.
It seems like backburner tries to call this as a function, so now should be passed here without calling it.
Suggested change
| trySet(run, 'backburner._platform.now', originalDate.now()); | |
| trySet(run, 'backburner._platform.now', originalDate.now); |
Contributor
|
Abit has changed since this PR was opened, therefore I've opened another one that is heavily inspired by these changes, but is up to date against the last ember version (4.4) (I've also made sure this comment is taken into account: #30 (comment)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emberdirectly.mockdate.