Conversation
3 tasks
github-actions
Bot
added
needs:gomod_comment
Replace time.Now().Sub(start) with time.Since(start) in the deferred duration calculation. This is more idiomatic and concise while preserving the same behavior when checking against the execution timeout; improves readability.
Introduce a new .env.example file providing a template of required environment variables for the application. Variables include daemon and scheduling settings (DAEMON, RUN_FREQUENCY, EXECUTION_TIMEOUT), observability and logging (SENTRY_DSN, JSON_LOGS, LOG_LEVEL), Discord integration (DISCORD_APPLICATION_ID, DISCORD_TOKEN, DISCORD_PROXY_HOST), DATABASE_URI, and MAX_REMOVALS_THRESHOLD to document configuration expectations for developers.
Adjust spacing/alignment of the struct literal fields in the rest.ListEntitlements call in internal/daemon/daemon.go to match project formatting (gofmt). This is a non-functional whitespace-only change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For: TicketsBot-cloud/gdl#12
Type of Change
Testing
Simply just test everything