fix a permissions UI bug

Author: Arlen22

packages/admin-vanilla/src/definition/renders.tsx

@@ -67,15 +67,9 @@ function getLookupOptions(fieldKey: string, itemsByTab: AdminRecordStore): strin
   if (fieldKey === "plugins") {
     return Array.from(new Set(itemsByTab.plugins.map((item) => item.name).filter(Boolean)));
   }
-  if (fieldKey === "userRoles") {
+  if (fieldKey === "userRoles" || fieldKey === "bagPermissions" || fieldKey === "templatePermissions" || fieldKey === "recipePermissions") {
     return Array.from(new Set(itemsByTab.roles.map((item) => item.name).filter(Boolean)));
   }
-  if (fieldKey === "permissions" || fieldKey === "recipePermissions") {
-    return Array.from(new Set([
-      ...itemsByTab.bags.flatMap((item) => item.bagPermissions.map((row) => row.role)),
-      ...itemsByTab.wikis.flatMap((item) => item.recipePermissions.map((row) => row.role)),
-    ].filter(Boolean)));
-  }
   return [];
 }
 

packages/admin-vanilla/src/definition/tabs.ts

@@ -382,7 +382,7 @@ const tabs = {
         { title: "Writable routing", description: writableRoutingDescription, keys: ["writablePrefixBags"], width: fullWidth },
         { title: "Bags", keys: ["readonlyBags"], width: halfWidth },
         { title: "Plugins", keys: ["plugins", "requiredPluginsEnabled"], width: halfWidth, layout: stackLayout },
-        { title: "Permissions", keys: ["templatePermissions"], width: fullWidth, layout: stackLayout },
+        { title: "Permissions", description: "Permissions for who can edit or use this template. Access to the template is required to apply it to a recipe, but not required to use that recipe.", keys: ["templatePermissions"], width: fullWidth, layout: stackLayout },
         { title: "Custom HTML shell", keys: ["htmlContent", "injectionArray", "injectionLocation"], headerFieldKey: "customHtmlEnabled", disabledWhenHeaderOff: true, width: fullWidth, layout: stackLayout },
       ],
       runtime: [