Update to .NET 10 SDK.#601
Conversation
Summary of ChangesHello @teo-tsirpanis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on modernizing the project's build infrastructure by upgrading the .NET SDK to version 10, the latest Long Term Support (LTS) release. This ensures that the project can be built with the most current tools and features, primarily impacting the build process for developers compiling from source. The change is isolated to the SDK version used for building and does not alter the application's runtime target framework, maintaining compatibility with existing deployments. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the .NET SDK version in global.json to 10.0.100. The change is straightforward, but I have one suggestion regarding the rollForward policy to improve build predictability and ensure the project stays on the intended major SDK version.
| { | ||
| "sdk": { | ||
| "version": "8.0.400", | ||
| "version": "10.0.100", |
There was a problem hiding this comment.
With this SDK version update, it's worth considering the rollForward policy on the next line. It's currently set to major, which could allow the project to build against a future major version of the SDK (e.g., .NET 11) if a .NET 10 SDK isn't found. To ensure builds are constrained to the .NET 10 major version, I'd recommend changing rollForward to minor. This will prevent builds from using a different major SDK version, improving build consistency.
shaunrd0
left a comment
There was a problem hiding this comment.
LGTM if there are no concerns for availability to customers on previous .NET versions (I think this is not the case, but FWIW)
This PR updates the .NET SDK version to 10, the latest LTS version, released in November.
.NET 10 will only be required to build TileDB-CSharp from source. No changes were made to the runtime target framework, which is expected to change from
net8.0tonet10.0at November 2026.