Skip to content

Update to .NET 10 SDK.#601

Merged
teo-tsirpanis merged 1 commit into
TileDB-Inc:mainfrom
teo-tsirpanis:net10-sdk
Dec 10, 2025
Merged

Update to .NET 10 SDK.#601
teo-tsirpanis merged 1 commit into
TileDB-Inc:mainfrom
teo-tsirpanis:net10-sdk

Conversation

@teo-tsirpanis

Copy link
Copy Markdown
Member

This PR updates the .NET SDK version to 10, the latest LTS version, released in November.

.NET 10 will only be required to build TileDB-CSharp from source. No changes were made to the runtime target framework, which is expected to change from net8.0 to net10.0 at November 2026.

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @teo-tsirpanis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on modernizing the project's build infrastructure by upgrading the .NET SDK to version 10, the latest Long Term Support (LTS) release. This ensures that the project can be built with the most current tools and features, primarily impacting the build process for developers compiling from source. The change is isolated to the SDK version used for building and does not alter the application's runtime target framework, maintaining compatibility with existing deployments.

Highlights

  • .NET SDK Update: The project's build environment has been updated to use the .NET 10 SDK, specifically version "10.0.100", by modifying the global.json file.
  • Build Requirement: This update primarily affects users building the project from source, requiring .NET 10 for compilation.
  • Runtime Target: The runtime target framework remains net8.0 and is not changed in this pull request, with an anticipated update to net10.0 in November 2026.
Ignored Files
  • Ignored by pattern: .github/workflows/** (5)
    • .github/workflows/docs.yml
    • .github/workflows/generate-bindings.yml
    • .github/workflows/nightly.yml
    • .github/workflows/release.yml
    • .github/workflows/tiledb-csharp.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .NET SDK version in global.json to 10.0.100. The change is straightforward, but I have one suggestion regarding the rollForward policy to improve build predictability and ensure the project stays on the intended major SDK version.

Comment thread global.json
{
"sdk": {
"version": "8.0.400",
"version": "10.0.100",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

With this SDK version update, it's worth considering the rollForward policy on the next line. It's currently set to major, which could allow the project to build against a future major version of the SDK (e.g., .NET 11) if a .NET 10 SDK isn't found. To ensure builds are constrained to the .NET 10 major version, I'd recommend changing rollForward to minor. This will prevent builds from using a different major SDK version, improving build consistency.

@shaunrd0 shaunrd0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if there are no concerns for availability to customers on previous .NET versions (I think this is not the case, but FWIW)

@teo-tsirpanis
teo-tsirpanis merged commit 6527528 into TileDB-Inc:main Dec 10, 2025
4 checks passed
@teo-tsirpanis
teo-tsirpanis deleted the net10-sdk branch December 10, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants