Skip to content

Update to .NET 10 SDK. #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teo-tsirpanis merged 1 commit into from
Dec 10, 2025
Merged

Update to .NET 10 SDK. #601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
- uses: actions/checkout@v6
- uses: actions/setup-dotnet@v5
with:
dotnet-version: 8.0.4xx
dotnet-version: 10.x
- name: Restore .NET local tools
run: dotnet tool restore
- name: Build docs
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/generate-bindings.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:

- uses: actions/setup-dotnet@v5
with:
dotnet-version: 8.0.4xx
dotnet-version: 10.x

- name: Run the binding generation script
run: dotnet msbuild ./scripts/generate-bindings/GenerateBindings.proj -p:Version=${{ inputs.version }} -p:VersionTag=${{ inputs.commit_id }} /restore
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ jobs:

- uses: actions/setup-dotnet@v5
with:
dotnet-version: 8.0.4xx
dotnet-version: 10.x

- name: Download native artifacts
uses: actions/download-artifact@v4
Expand Down Expand Up @@ -113,8 +113,10 @@ jobs:
- name: Checkout TileDB-CSharp
uses: actions/checkout@v6

- name: Set up .NET SDK from global.json
- name: Set up .NET SDK
uses: actions/setup-dotnet@v5
with:
dotnet-version: 10.x

- name: Download native NuGet packages
uses: actions/download-artifact@v4
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- uses: actions/checkout@v6
- uses: actions/setup-dotnet@v5
with:
dotnet-version: 8.0.4xx
dotnet-version: 10.x
- name: Pack TileDB.CSharp
run: dotnet pack -c Release ./sources/TileDB.CSharp/TileDB.CSharp.csproj -o pack
# In case pushing to NuGet fails we upload the packages as artifacts to push them ourselves.
Expand All @@ -34,7 +34,7 @@ jobs:
- uses: actions/checkout@v6
- uses: actions/setup-dotnet@v5
with:
dotnet-version: 8.0.4xx
dotnet-version: 10.x
- name: Obtain NuGet API token
uses: nuget/login@v1
id: nuget-login
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/tiledb-csharp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:

- uses: actions/setup-dotnet@v5
with:
dotnet-version: 8.0.4xx
dotnet-version: 10.x

# Package validation runs as part of packing.
- name: Dotnet pack for TileDB.CSharp
Expand All @@ -37,7 +37,7 @@ jobs:

- uses: actions/setup-dotnet@v5
with:
dotnet-version: 8.0.4xx
dotnet-version: 10.x

# DotNet build
- name: Dotnet build for TileDB.CSharp
Expand Down
2 changes: 1 addition & 1 deletion global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"sdk": {
"version": "8.0.400",
"version": "10.0.100",

@gemini-code-assist gemini-code-assist Bot Dec 9, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

With this SDK version update, it's worth considering the rollForward policy on the next line. It's currently set to major, which could allow the project to build against a future major version of the SDK (e.g., .NET 11) if a .NET 10 SDK isn't found. To ensure builds are constrained to the .NET 10 major version, I'd recommend changing rollForward to minor. This will prevent builds from using a different major SDK version, improving build consistency.

"rollForward": "major"
}
}
Loading