Add support for AWS KMS key ID with credentials#492
Merged
Shelnutt2 merged 2 commits intoAug 4, 2025
Conversation
This adds a new parameter to AWSCredential/AWSRole to allow a user to associate a KMS key arn with the credential to be used. This allows the system to support KMS based s3 encryption in a more automated fashion without the user having to pass the key arn for each request manually.
teo-tsirpanis
requested changes
Aug 1, 2025
teo-tsirpanis
approved these changes
Aug 1, 2025
This is based on reviewer feedback.
Shelnutt2
deleted the
seth/cloud-1273-add-tiledb-cloud-rest-support-for-kms-key
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new parameter to AWSCredential/AWSRole to allow a user to associate a KMS key arn with the credential to be used. This allows the system to support KMS based s3 encryption in a more automated fashion without the user having to pass the key arn for each request manually.