Escape null characters in schema dumps (#825)

* Escape null characters in schema dumps

* DESCRIPTION and NEWS.md

Author: johnkerl

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: tiledb
 Type: Package
-Version: 0.32.0.2
+Version: 0.32.0.3
 Title: Modern Database Engine for Complex Data Based on Multi-Dimensional Arrays
 Authors@R: c(
   person("TileDB, Inc.", role = c("aut", "cph")),

NEWS.md

@@ -2,6 +2,7 @@
 
 ## Improvements
 
+* Schema-dump output is no longer truncated in the case that there are any null fill values in the schema (@johnkerl in [#825](https://github.com/TileDB-Inc/TileDB-R/pull/825))
 * `tiledb_attr()` now prints the attribute object as expected and documentation has been corrected (@cgiachalis in [#823](https://github.com/TileDB-Inc/TileDB-R/pull/823))
 
 ## Documentation

src/libtiledb.cpp

@@ -24,10 +24,27 @@
 #include "tiledb_version.h"
 
 #include <fstream>
+#include <algorithm>
 #include <unistd.h>
 
 using namespace Rcpp;
 
+// This is an auxiliary method for schema dumps wherein a fill value may include
+// the null character. It isn't a general-purpose C++ string-search-and-replace,
+// as C++ makes that a surprisingly non-straightforward operation. This suffices
+// for our purposes.
+std::string denull(const std::string& str) {
+  std::stringstream ss;
+  for (char c : str) {
+    if (c == '\0') {
+      ss << "\\0";
+    } else {
+      ss << c;
+    }
+  }
+  return ss.str();
+}
+
 const char *_tiledb_datatype_to_string(tiledb_datatype_t dtype) {
   switch (dtype) {
   case TILEDB_INT8:
@@ -1302,13 +1319,14 @@ bool libtiledb_domain_has_dimension(XPtr<tiledb::Domain> domain,
   return domain->has_dimension(name.c_str());
 }
 
+
 // [[Rcpp::export]]
 void libtiledb_domain_dump(XPtr<tiledb::Domain> domain) {
   check_xptr_tag<tiledb::Domain>(domain);
 #if TILEDB_VERSION >= TileDB_Version(2, 25, 0)
   std::stringstream ss;
   ss << *domain;
-  Rcpp::Rcout << ss.str();
+  Rcpp::Rcout << denull(ss.str());
 #else
   domain->dump();
 #endif
@@ -1624,7 +1642,7 @@ void libtiledb_attribute_dump(XPtr<tiledb::Attribute> attr) {
 #if TILEDB_VERSION >= TileDB_Version(2, 25, 0)
   std::stringstream ss;
   ss << *attr;
-  Rcpp::Rcout << ss.str();
+  Rcpp::Rcout << denull(ss.str());
 #else
   attr->dump();
 #endif
@@ -2182,7 +2200,7 @@ void libtiledb_array_schema_dump(XPtr<tiledb::ArraySchema> schema) {
 #if TILEDB_VERSION >= TileDB_Version(2, 25, 0)
   std::stringstream ss;
   ss << *schema;
-  Rcpp::Rcout << ss.str();
+  Rcpp::Rcout << denull(ss.str());
 #else
   schema->dump();
 #endif