Relevel a factor column when adding a subset of current factors#844
Merged
mojaveazure merged 5 commits intoSep 30, 2025
Merged
Conversation
862b5e5 to
93cd034
Compare
93cd034 to
26de769
Compare
mojaveazure
approved these changes
Sep 30, 2025
mojaveazure
left a comment
Member
There was a problem hiding this comment.
Sorry for the delay in review; this looks good. I've made one suggestion below, but it's optional. Can you bump the develop version and add an entry to NEWS.md before we merge?
Co-authored-by: Paul Hoffman <mojaveazure@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a first attempt to fix #843.
When an array has factor columns, any new writes that includes only a subset of existing factor levels will not remap these levels accurately.
Unit tests are added to cover the cases of new writes with current factors only (not growing enums).
Before
After