Removed enable_progress_estimation member from Reader class

Author: alancleary

libtiledbvcf/src/read/reader.cc

@@ -706,29 +706,6 @@ bool Reader::next_read_batch_v2_v3() {
   // Get estimated records for verbose output
   read_state_.total_query_records_processed = 0;
   read_state_.query_estimated_num_records = 1;
-  if (params_.enable_progress_estimation) {
-    if (dataset_->metadata().version == TileDBVCFDataset::Version::V2) {
-      read_state_.query_estimated_num_records =
-          read_state_.query->est_result_size(
-              TileDBVCFDataset::DimensionNames::V2::end_pos) /
-          tiledb_datatype_size(
-              dataset_->data_array()
-                  ->schema()
-                  .domain()
-                  .dimension(TileDBVCFDataset::DimensionNames::V2::end_pos)
-                  .type());
-    } else {
-      read_state_.query_estimated_num_records =
-          read_state_.query->est_result_size(
-              TileDBVCFDataset::DimensionNames::V3::start_pos) /
-          tiledb_datatype_size(
-              dataset_->data_array()
-                  ->schema()
-                  .domain()
-                  .dimension(TileDBVCFDataset::DimensionNames::V3::start_pos)
-                  .type());
-    }
-  }
 
   return true;
 }
@@ -935,18 +912,6 @@ bool Reader::next_read_batch_v4() {
   read_state_.total_query_records_processed = 0;
   read_state_.query_estimated_num_records = 1;
 
-  if (params_.enable_progress_estimation) {
-    read_state_.query_estimated_num_records =
-        read_state_.query->est_result_size(
-            TileDBVCFDataset::DimensionNames::V4::start_pos) /
-        tiledb_datatype_size(
-            dataset_->data_array()
-                ->schema()
-                .domain()
-                .dimension(TileDBVCFDataset::DimensionNames::V4::start_pos)
-                .type());
-  }
-
   return true;
 }
 
@@ -1154,26 +1119,11 @@ bool Reader::read_current_batch() {
       complete = process_query_results_v2();
     }
 
-    if (params_.enable_progress_estimation &&
-        read_state_.query_estimated_num_records > 0) {
-      LOG_INFO(
-          "Processed {} cells in {:.3f} sec. Reported {} cells. Approximately "
-          "{:.1f}% completed with query cells.",
-          read_state_.query_results.num_cells(),
-          utils::chrono_duration(processing_start_timer),
-          read_state_.last_num_records_exported - old_num_exported,
-          std::min(
-              100.0,
-              read_state_.total_query_records_processed /
-                  static_cast<double>(read_state_.query_estimated_num_records) *
-                  100.0));
-    } else {
-      LOG_INFO(
-          "Processed {} cells in {:.3f} sec. Reported {} cells.",
-          read_state_.query_results.num_cells(),
-          utils::chrono_duration(processing_start_timer),
-          read_state_.last_num_records_exported - old_num_exported);
-    }
+    LOG_INFO(
+        "Processed {} cells in {:.3f} sec. Reported {} cells.",
+        read_state_.query_results.num_cells(),
+        utils::chrono_duration(processing_start_timer),
+        read_state_.last_num_records_exported - old_num_exported);
 
     // Return early if we couldn't process all the results.
     if (!complete)
@@ -2808,13 +2758,6 @@ void Reader::set_check_samples_exist(const bool check_samples_exist) {
   params_.check_samples_exist = check_samples_exist;
 }
 
-void Reader::set_enable_progress_estimation(
-    const bool& enable_progress_estimation) {
-  LOG_DEBUG(
-      "setting enable_progress_estimation to {}", enable_progress_estimation);
-  params_.enable_progress_estimation = enable_progress_estimation;
-}
-
 void Reader::set_debug_print_vcf_regions(const bool print_vcf_regions) {
   params_.debug_params.print_vcf_regions = print_vcf_regions;
 }

libtiledbvcf/src/read/reader.h

@@ -123,11 +123,6 @@ struct ExportParams {
   // because we have to fetch the list of samples from the VCF header array
   bool check_samples_exist = true;
 
-  // Should we skip trying to estimate the number of records and percent
-  // complete? This is useful when you want verbose but not the performance
-  // impact.
-  bool enable_progress_estimation = false;
-
   // Debug parameters for optional debug information
   struct DebugParams debug_params;
 
@@ -521,12 +516,6 @@ class Reader {
    */
   void set_scan_all_samples(bool scan_all_samples);
 
-  /**
-   * Sets disabling of progress estimation in verbose mode
-   * @param enable_progress_estimation setting
-   */
-  void set_enable_progress_estimation(const bool& enable_progress_estimation);
-
   /**
    * Percentage of buffer size to tiledb memory budget
    * @param buffer_percentage