Skip to content

Support pybind11 3.0 #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alancleary merged 1 commit into from
Apr 10, 2026
Merged

Support pybind11 3.0 #883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apis/python/src/tiledbvcf/binding/pyarrow_helpers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ using namespace tiledb::vcf;
* @return py::object Arrow table
*/
py::object _buffer_to_table(std::shared_ptr<ArrayBuffers> buffers) {
auto pa = py::module::import("pyarrow");
auto pa = py::module_::import("pyarrow");
auto pa_table_from_arrays = pa.attr("Table").attr("from_arrays");
auto pa_array_import = pa.attr("Array").attr("_import_from_c");
auto pa_schema_import = pa.attr("Schema").attr("_import_from_c");
Expand Down
2 changes: 1 addition & 1 deletion apis/python/src/tiledbvcf/binding/sample_stats.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ namespace py = pybind11;
using namespace py::literals;
using namespace tiledb::vcf;

void load_sample_stats(py::module& m) {
void load_sample_stats(py::module_& m) {
m.def(
"sample_qc",
[](const std::string& dataset_uri,
Expand Down
2 changes: 1 addition & 1 deletion apis/python/src/tiledbvcf/binding/vcf_arrow.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ void build_arrow_array_from_buffer(
}

py::object buffers_to_table(std::vector<std::shared_ptr<BufferInfo>>& buffers) {
auto pa = py::module::import("pyarrow");
auto pa = py::module_::import("pyarrow");
auto pa_table_from_arrays = pa.attr("Table").attr("from_arrays");
auto pa_array_import = pa.attr("Array").attr("_import_from_c");
auto pa_schema_import = pa.attr("Schema").attr("_import_from_c");
Expand Down
Loading