Skip to content

Commit 202125a

Browse files
Fix backwards compatibility tests on Windows. (#595)
* Treat backwards compatibility arrays as binary files. * Remove redundant README. * Stop skipping tests on Windows. * Fix wildcard. * Treat all test data as binary.
1 parent 7189aad commit 202125a

3 files changed

Lines changed: 2 additions & 13 deletions

File tree

.gitattributes

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,4 @@
11
.git_archival.txt export-subst
22
*.qmd linguist-language=RMarkdown
3+
backwards-compatibility-data/data/**/* binary
4+
external/test-data/**/* binary

backwards-compatibility-data/data/README.md

Lines changed: 0 additions & 3 deletions
This file was deleted.

src/include/test/unit_backwards_compatibility.cc

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -89,16 +89,6 @@ TEST_CASE("test_query_old_indices", "[backwards_compatibility]") {
8989
continue;
9090
}
9191

92-
// Skip pre-0.16.0 versions on Windows due to blosc1/blosc2
93-
// incompatibility. TileDB 2.30.0+ uses blosc2, but older test data was
94-
// compressed with blosc1. blosc2 has a Windows-specific bug when
95-
// decompressing blosc1 data.
96-
#ifdef _WIN32
97-
if (index_uri.find("0.16.0") == std::string::npos) {
98-
continue;
99-
}
100-
#endif
101-
10292
auto read_group = tiledb::Group(ctx, index_uri, TILEDB_READ, cfg);
10393
std::vector<float> expected_distances(query_indices.size(), 0.0);
10494
if (index_uri.find("ivf_flat") != std::string::npos) {

0 commit comments

Comments
 (0)