fix(security): 2 improvements across 1 files#120
Open
tomaioo wants to merge 1 commit into
Open
Conversation
- Security: Hardcoded JWT Secret in Database Configuration - Security: Hardcoded MongoDB Connection Strings Without Authentication Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 1 files
Problem
Severity:
Critical| File:config/database.js:L1The database configuration file contains a hardcoded JWT secret 'nodeauthsecret' which is used for authentication. Hardcoded secrets are a critical security risk as they can be easily extracted from source code and used to forge authentication tokens.
Solution
Remove the hardcoded secret and load it exclusively from environment variables. Ensure the secret is sufficiently long and random (at least 256 bits). Rotate any secrets that may have been exposed.
Changes
config/database.js(modified)