Skip to content

make language field of session optional #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheCommCraft merged 1 commit into from
Jun 20, 2026
Merged

make language field of session optional #666

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scratchattach/site/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ class Session(BaseSiteComponent):
is_teacher: bool = field(repr=False, default=None)

time_created: datetime.datetime = None
language: str = field(repr=False, default="en")
language: Optional[str] = field(repr=False, default="en")

def __str__(self) -> str:
return f"<Login for {self.username!r}>"
Expand Down Expand Up @@ -161,7 +161,7 @@ def _process_session_id(self):

# not saving the login ip because it is a security issue, and is not very helpful

self.language = data["_language"]
self.language = data.get("_language")
# self._cookies["scratchlanguage"] = self.language

def connect_linked_user(self) -> user.User:
Expand Down
Loading