Fix error check on X509V3_EXT_print()

ndossche · ndossche · commit 568494933700 · 2026-04-03T22:48:32.000+02:00
The docs I found of this function appear to be wrong, as it can also return -1 on failure. See also openssl/openssl#29793 Closes phpGH-21047.
diff --git a/ext/openssl/openssl.c b/ext/openssl/openssl.c
@@ -2252,7 +2252,7 @@ PHP_FUNCTION(openssl_x509_parse)
 				goto err_subitem;
 			}
 		}
-		else if (X509V3_EXT_print(bio_out, extension, 0, 0)) {
+		else if (X509V3_EXT_print(bio_out, extension, 0, 0) > 0) {
 			BIO_get_mem_ptr(bio_out, &bio_buf);
 			add_assoc_stringl(&subitem, extname, bio_buf->data, bio_buf->length);
 		} else {

Original file line number	Diff line number	Diff line change
`@@ -2252,7 +2252,7 @@ PHP_FUNCTION(openssl_x509_parse)`
`2252`	`2252`	`goto err_subitem;`
`2253`	`2253`	`}`
`2254`	`2254`	`}`
`2255`		`- else if (X509V3_EXT_print(bio_out, extension, 0, 0)) {`
	`2255`	`+ else if (X509V3_EXT_print(bio_out, extension, 0, 0) > 0) {`
`2256`	`2256`	`BIO_get_mem_ptr(bio_out, &bio_buf);`
`2257`	`2257`	`add_assoc_stringl(&subitem, extname, bio_buf->data, bio_buf->length);`
`2258`	`2258`	`} else {`