uri: Preinitialize errors array with the correct size in fill_errors() (php#21560)

LamentXU123 · web-flow · commit 78f2d4409005 · 2026-03-28T16:35:34.000+01:00
diff --git a/ext/uri/uri_parser_whatwg.c b/ext/uri/uri_parser_whatwg.c
@@ -62,12 +62,13 @@ static zend_always_inline void zval_long_or_null_to_lexbor_str(zval *value, lexb
  */
 static const char *fill_errors(zval *errors)
 {
-	if (lexbor_parser.log == NULL || lexbor_plog_length(lexbor_parser.log) == 0) {
+	size_t log_len;
+	if (lexbor_parser.log == NULL || (log_len = lexbor_plog_length(lexbor_parser.log)) == 0) {
 		ZVAL_EMPTY_ARRAY(errors);
 		return NULL;
 	}
 
-	array_init(errors);
+	array_init_size(errors, log_len);
 	const char *result = NULL;
 
 	lexbor_plog_entry_t *lxb_error;

Original file line number	Diff line number	Diff line change
`@@ -62,12 +62,13 @@ static zend_always_inline void zval_long_or_null_to_lexbor_str(zval *value, lexb`
`62`	`62`	`*/`
`63`	`63`	`static const char fill_errors(zval errors)`
`64`	`64`	`{`
`65`		`- if (lexbor_parser.log == NULL \|\| lexbor_plog_length(lexbor_parser.log) == 0) {`
	`65`	`+ size_t log_len;`
	`66`	`+ if (lexbor_parser.log == NULL \|\| (log_len = lexbor_plog_length(lexbor_parser.log)) == 0) {`
`66`	`67`	`ZVAL_EMPTY_ARRAY(errors);`
`67`	`68`	`return NULL;`
`68`	`69`	`}`
`69`	`70`
`70`		`- array_init(errors);`
	`71`	`+ array_init_size(errors, log_len);`
`71`	`72`	`const char *result = NULL;`
`72`	`73`
`73`	`74`	`lexbor_plog_entry_t *lxb_error;`