Zlib: Fix the bug when zval_get_long silently cast $strategy into long in deflate_init (php#21841)

Author: LamentXU123

NEWS

@@ -197,4 +197,8 @@ PHP                                                                        NEWS
   . Added ZipArchive::openString() method.
     (Tim Starling, Soner Sayakci, Ghaith Olabi)
 
+- Zlib:
+  . deflate_init() now raises a TypeError when the value for option
+    "strategy" is not of type int. (Weilin Du)
+
 <<< NOTE: Insert NEWS from last stable release here prior to actual release! >>>

UPGRADING

@@ -101,6 +101,10 @@ PHP 8.6 UPGRADE NOTES
     files argument if one or more of the entries is not
     a string.
 
+- Zlib:
+  . deflate_init() now raises a TypeError when the value for option
+    "strategy" is not of type int.
+
 ========================================
 2. New Features
 ========================================

ext/zlib/tests/deflate_init_strategy_type_error.phpt

@@ -0,0 +1,16 @@
+--TEST--
+deflate_init(): strategy option type validation
+--EXTENSIONS--
+zlib
+--FILE--
+<?php
+
+try {
+    deflate_init(ZLIB_ENCODING_DEFLATE, ['strategy' => []]);
+} catch (TypeError $e) {
+    echo $e->getMessage(), PHP_EOL;
+}
+
+?>
+--EXPECT--
+deflate_init(): Argument #2 ($options) the value for option "strategy" must be of type int, array given

ext/zlib/zlib.c

@@ -1115,8 +1115,14 @@ PHP_FUNCTION(deflate_init)
 	}
 
 	if (options && (option_buffer = zend_hash_str_find(options, ZEND_STRL("strategy"))) != NULL) {
+		bool failed = false;
+
 		ZVAL_DEINDIRECT(option_buffer);
-		strategy = zval_get_long(option_buffer);
+		strategy = zval_try_get_long(option_buffer, &failed);
+		if (UNEXPECTED(failed)) {
+			zend_argument_type_error(2, "the value for option \"strategy\" must be of type int, %s given", zend_zval_value_name(option_buffer));
+			RETURN_THROWS();
+		}
 	}
 	switch (strategy) {
 		case Z_FILTERED: