Merge pull request #74 from TimeWarpEngineering/version-bump-beta.27

feat: disable StreamJsonRpc-based JSON-RPC to unblock AOT consumers

Author: StevenTCramer

Directory.Packages.props

@@ -6,7 +6,7 @@
   <ItemGroup>
     <!-- External packages -->
     <PackageVersion Include="CliWrap" Version="3.10.1" />
-    <PackageVersion Include="ModelContextProtocol.Core" Version="1.0.0" />
+    <PackageVersion Include="ModelContextProtocol.Core" Version="1.2.0" />
     <PackageVersion Include="NuGet.Common" Version="7.3.0" />
     <PackageVersion Include="NuGet.Configuration" Version="7.3.0" />
     <PackageVersion Include="NuGet.Protocol" Version="7.3.0" />
@@ -15,7 +15,7 @@
     <PackageVersion Include="StreamJsonRpc" Version="2.24.84" />
     <PackageVersion Include="TimeWarp.Build.Tasks" Version="1.0.0" />
     <PackageVersion Include="TimeWarp.Jaribu" Version="1.0.0-beta.12" />
-    <PackageVersion Include="TimeWarp.Nuru" Version="3.0.0-beta.67" />
+    <PackageVersion Include="TimeWarp.Nuru" Version="3.0.0-beta.68" />
     <PackageVersion Include="TimeWarp.Terminal" Version="1.0.0-beta.12" />
 
     <!-- Analyzers -->
@@ -24,7 +24,7 @@
     <PackageVersion Include="Roslynator.Formatting.Analyzers" Version="4.15.0" />
     <PackageVersion Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="10.0.201" />
     <PackageVersion Include="Microsoft.CodeAnalysis.CSharp.CodeStyle" Version="5.3.0" />
-    <PackageVersion Include="Microsoft.CodeAnalysis.BannedApiAnalyzers" Version="3.3.4" />
+    <PackageVersion Include="Microsoft.CodeAnalysis.BannedApiAnalyzers" Version="4.14.0" />
 
   </ItemGroup>
 </Project>

kanban/done/080-clean-up-rs0030-banned-symbol-audit-issues.md

@@ -0,0 +1,37 @@
+# Clean up RS0030 banned symbol audit issues
+
+## Description
+
+Review and resolve RS0030 banned symbol warnings throughout the repository. The project uses a banned symbol analyzer to enforce use of TimeWarp.Amuru's `Shell.Builder` instead of raw `System.Diagnostics.Process` and `ProcessStartInfo`.
+
+## Checklist
+
+- [x] Audit all RS0030 pragma exemptions in the codebase
+- [x] Evaluate if `SshKeyHelper.cs` should use Shell.Builder instead of raw Process/ProcessStartInfo
+- [x] Evaluate if `CommandResult.cs` TtyPassthroughAsync needs Process directly (TTY inheritance requirement)
+- [x] Document legitimate exemptions with clear justification comments
+- [x] Refactor any code that should use Amuru's API but doesn't
+- [x] Consider if banned symbol configuration needs adjustment for Amuru's own source
+
+## Notes
+
+### Final State
+
+Only one RS0030 pragma exemption remains in the entire codebase:
+
+1. `source/timewarp-amuru/core/command-result.cs` — `TtyPassthroughAsync`
+   - **Legitimate**: True TTY inheritance requires `Process.Start` without stream redirection; CliWrap cannot express this
+   - **Documented**: `#pragma warning disable RS0030` with justification comment, plus `#region Implementation Boundaries` explaining the design decision
+
+All other RS0030 exemptions have been eliminated:
+- `SshKeyHelper.cs` — refactored to use `Shell.Builder`
+- Test files (`fzf-builder.select-async.cs`, `shell-builder.select-async.cs`) — replaced `ProcessStartInfo` with `Shell.Builder`
+- `tools/dev-cli/services/process-helpers.cs` — replaced `ProcessStartInfo` with `Shell.Builder` + argument parser
+
+### Banned Symbol Configuration
+
+No adjustment needed. The single remaining exemption in `command-result.cs` is properly justified and documented. Amuru correctly "eats its own dog food" — it uses `Shell.Builder` everywhere except for the one case where raw process APIs are architecturally required (TTY passthrough).
+
+### Architectural Decision
+
+Amuru should use `Shell.Builder` internally wherever possible. The only exception is `TtyPassthroughAsync`, which is an implementation boundary where raw process APIs are required because CliWrap's stream-piped model cannot preserve TTY characteristics. This is documented in `#region Implementation Boundaries` in the source file.

kanban/in-progress/080-clean-up-rs0030-banned-symbol-audit-issues.md

@@ -0,0 +1,158 @@
+# Clean up repository to follow kebab-case naming and C# conventions
+
+## Description
+
+Audit and clean up the entire repository to ensure consistent kebab-case file naming and proper C# documentation conventions per the csharp skill. This includes renaming files from PascalCase to kebab-case and replacing all "TODO: Add purpose description" region comments with proper Purpose/Design/Responsibilities documentation.
+
+## Scope
+
+This is a large-scale style cleanup task affecting the entire codebase. It should be done in manageable chunks to keep PRs reviewable.
+
+## Checklist
+
+### Phase 1: Core Files (source/timewarp-amuru/)
+- [ ] Rename `AppContextExtensions.cs` → `app-context-extensions.cs`
+- [ ] Rename `CliConfiguration.cs` → `cli-configuration.cs`
+- [ ] Rename `ScriptContext.cs` → `script-context.cs`
+- [ ] Rename `PathResolver.cs` → `path-resolver.cs`
+- [ ] Rename `Installer.cs` → `installer.cs`
+- [ ] Update regions in all core files with proper Purpose/Design descriptions
+
+### Phase 2: DotNet Commands (source/timewarp-amuru/dot-net-commands/)
+- [ ] Rename `DotNet.cs` → `dot-net.cs`
+- [ ] Rename `DotNet.*.cs` files → `dot-net.*.cs` (kebab-case)
+- [ ] Rename tool subdirectory files
+- [ ] Update regions in all dotnet command files
+
+### Phase 3: Git Commands (source/timewarp-amuru/git-commands/)
+- [ ] Rename `Git.cs` → `git.cs`
+- [ ] Rename `Git.*.cs` → `git.*.cs` (kebab-case)
+- [ ] Update regions in all git command files
+
+### Phase 4: Fzf Commands (source/timewarp-amuru/fzf-command/)
+- [ ] Rename `Fzf.cs` → `fzf.cs`
+- [ ] Rename `Fzf.*.cs` → `fzf.*.cs` (kebab-case)
+- [ ] Update regions in all fzf command files
+
+### Phase 5: Native/FileSystem (source/timewarp-amuru/native/)
+- [ ] Rename `Bash.cs` → `bash.cs`
+- [ ] Rename file-system commands (`Commands.*.cs` → `commands.*.cs`)
+- [ ] Rename file-system direct (`Direct.*.cs` → `direct.*.cs`)
+- [ ] Rename utilities (`Post.cs`, `GenerateColor.cs`, etc.)
+- [ ] Rename `PathResolver.cs`
+- [ ] Update regions in all native files
+
+### Phase 6: JSON-RPC (source/timewarp-amuru/json-rpc/)
+- [ ] Rename `JsonRpcClient.cs` → `json-rpc-client.cs`
+- [ ] Rename `JsonRpcClientBuilder.cs` → `json-rpc-client-builder.cs`
+- [ ] Rename `IJsonRpcClient.cs` → `ijson-rpc-client.cs`
+- [ ] Update regions
+
+### Phase 7: Testing (source/timewarp-amuru/testing/)
+- [ ] Rename `CommandMock.cs` → `command-mock.cs`
+- [ ] Rename `MockScope.cs` → `mock-scope.cs`
+- [ ] Rename `MockState.cs` → `mock-state.cs`
+- [ ] Rename `MockSetup.cs` → `mock-setup.cs`
+- [ ] Update regions
+
+### Phase 8: Interfaces & Extensions
+- [ ] Rename `ICommandBuilder.cs` → `icommand-builder.cs`
+- [ ] Rename `CommandBuilderExtensions.cs` → `command-builder-extensions.cs`
+- [ ] Update regions
+
+### Phase 9: Tests (tests/)
+- [ ] Audit test files for PascalCase naming
+- [ ] Rename test files to kebab-case
+- [ ] Update regions in test files
+
+### Phase 10: Final Verification
+- [ ] Run `dotnet build` to verify no compilation errors
+- [ ] Run `dev test` to verify all tests pass
+- [ ] Check for any remaining PascalCase files
+- [ ] Check for any remaining "TODO: Add purpose" comments
+- [ ] Update documentation references if needed
+
+## Region Documentation Template
+
+All files should follow this pattern (see csharp skill):
+
+```csharp
+#region Purpose
+// One-line description of what this file/class does
+#endregion
+
+#region Design
+// Key design decisions and rationale
+// Constraints and dependencies
+// Why certain approaches were chosen
+#endregion
+
+#region Responsibilities (optional)
+// What this class/file is responsible for
+// What it is NOT responsible for
+#endregion
+
+#region Open Questions (optional)
+// Q1 (YYYY-MM-DD, author): question text
+// A1 (YYYY-MM-DD, author): answer text
+#endregion
+```
+
+## Notes
+
+### Current State
+- 96 files have "TODO: Add purpose description" in their regions
+- Many files still use PascalCase naming (e.g., `AppContextExtensions.cs`, `CliConfiguration.cs`)
+- The `core/` folder has been cleaned up (completed in tasks 080/081)
+- The `nu-get/` folder has been cleaned up (completed in task 081)
+
+### Approach
+1. Work folder-by-folder to keep commits focused
+2. Each rename + region update should be a single commit
+3. Create small PRs (one folder per PR) for easier review
+4. Run tests after each folder cleanup
+
+### Reference
+- See `.ai/04-csharp-coding-standards.md` for C# conventions
+- See `csharp` skill for region documentation patterns
+- Examples of good collocated docs:
+  - `source/timewarp-amuru/core/command-extensions.cs`
+  - `source/timewarp-amuru/core/command-result.cs`
+
+### Files with TODO: comments (96 total)
+
+**Core (6 files):**
+- AppContextExtensions.cs
+- CliConfiguration.cs
+- Installer.cs
+- ScriptContext.cs
+- core/shell-builder.cs
+- interfaces/ICommandBuilder.cs
+
+**DotNet Commands (25 files):**
+- DotNet.cs, DotNet.*.cs, tool/DotNet.*.cs
+
+**Git Commands (17 files):**
+- Git.cs, Git.*.cs
+
+**Fzf Commands (10 files):**
+- Fzf.cs, Fzf.*.cs
+
+**JSON-RPC (3 files):**
+- JsonRpcClient.cs, JsonRpcClientBuilder.cs, IJsonRpcClient.cs
+
+**Native (14 files):**
+- Bash.cs, utilities/*, file-system/commands/*, file-system/direct/*, PathResolver.cs
+
+**Testing (4 files):**
+- CommandMock.cs, MockScope.cs, MockState.cs, MockSetup.cs
+
+**Extensions (1 file):**
+- CommandBuilderExtensions.cs
+
+**Tests (spike files, may be lower priority):**
+- cliwrap-exit-code-tests/*.cs (9 files)
+
+## Session
+
+- Created: ses_27dd18c7effe1K4rnFRhnQezjn (2026-04-13)

kanban/in-progress/082-clean-up-repository-to-follow-kebab-case-naming-and-c-conventions/task.md

@@ -0,0 +1,61 @@
+# Unblock AOT consumers by disabling StreamJsonRpc-based JSON-RPC support
+
+## Description
+
+Temporarily disable Amuru's current `StreamJsonRpc`-based JSON-RPC feature slice so downstream AOT consumers no longer inherit the `Newtonsoft.Json` dependency and related trimming/native AOT issues.
+
+This is an intentional interim step. The JSON-RPC feature should preserve design intent in commented/disabled code where useful, while a replacement is developed separately in task 083.
+
+## Checklist
+
+- [x] Remove or comment out the `StreamJsonRpc` package reference from `source/timewarp-amuru/timewarp-amuru.csproj`
+- [x] Remove or comment out `global using StreamJsonRpc` from `source/timewarp-amuru/global-usings.cs`
+- [x] Disable `source/timewarp-amuru/json-rpc/IJsonRpcClient.cs`
+- [x] Disable `source/timewarp-amuru/json-rpc/JsonRpcClient.cs`
+- [x] Disable `source/timewarp-amuru/json-rpc/JsonRpcClientBuilder.cs`
+- [x] Disable `ShellBuilder.AsJsonRpcClient()` in `source/timewarp-amuru/core/shell-builder.cs`
+- [ ] Add clear temporary comments explaining JSON-RPC is disabled pending task 083
+- [x] Ensure the rest of Amuru builds without `StreamJsonRpc`
+- [ ] Verify AOT consumers no longer inherit `Newtonsoft.Json` through Amuru
+- [ ] Update any docs/samples that incorrectly imply JSON-RPC support is active
+
+## Session
+
+- Created: ses_27dd18c7effe1K4rnFRhnQezjn (2026-04-14)
+
+## Notes
+
+### Why this task exists
+
+`StreamJsonRpc` still carries a direct `Newtonsoft.Json` dependency in current releases and prereleases. This dependency pollutes downstream consumers of Amuru and creates NativeAOT/trimming pain, even when Amuru does not use the legacy Newtonsoft formatter path at runtime.
+
+### Scope
+
+This task is about **temporarily disabling** the current JSON-RPC feature slice so Amuru's core package remains AOT-friendly.
+
+It is **not** the task to implement the replacement. That work belongs in task 083:
+
+- `083-replace-streamjsonrpc-with-amuru-native-minimal-json-rpc-client`
+
+### What the spike proved
+
+A local build experiment showed that Amuru builds successfully without `StreamJsonRpc` once the following are disabled:
+
+- `global-usings.cs` reference to `StreamJsonRpc`
+- `json-rpc/` source files
+- `ShellBuilder.AsJsonRpcClient()`
+- `timewarp-amuru.csproj` package reference
+
+This means the dependency is isolated to the JSON-RPC feature slice and can be temporarily turned off without breaking the rest of the package.
+
+### Current progress
+
+- The package reference and global using are commented out
+- The three `json-rpc/` source files are commented out
+- `ShellBuilder.AsJsonRpcClient()` is commented out
+- `dotnet build source/timewarp-amuru/timewarp-amuru.csproj` succeeds without `StreamJsonRpc`
+- Remaining follow-up for this task is mainly cleanup/documentation and downstream AOT validation
+
+### Intent
+
+Because this is still beta and AOT matters more than preserving unfinished API surface, temporarily disabled code is acceptable here as a staging move. The goal is to unblock consumers now, while preserving enough intent to guide the native replacement.