fix: stop dev workflow after first failed step

Author: StevenTCramer

tools/dev-cli/endpoints/workflow-command.cs

@@ -89,46 +89,64 @@ private async Task RunPrWorkflowAsync()
       Terminal.WriteLine("Pipeline: clean -> build -> verify-samples -> test -> check-version");
       Terminal.WriteLine("");
 
+      Environment.ExitCode = 0;
+
       Terminal.WriteLine("===============================================================================");
       Terminal.WriteLine("  Step 1/5: Clean");
       Terminal.WriteLine("===============================================================================");
       CleanCommand.Handler cleanHandler = new();
       await cleanHandler.Handle(new CleanCommand(), CancellationToken.None);
 
+      if (StopOnFailure("Clean"))
+      {
+        return;
+      }
+
       Terminal.WriteLine("");
       Terminal.WriteLine("===============================================================================");
       Terminal.WriteLine("  Step 2/5: Build");
       Terminal.WriteLine("===============================================================================");
       BuildCommand.Handler buildHandler = new();
       await buildHandler.Handle(new BuildCommand(), CancellationToken.None);
 
+      if (StopOnFailure("Build"))
+      {
+        return;
+      }
+
       Terminal.WriteLine("");
       Terminal.WriteLine("===============================================================================");
       Terminal.WriteLine("  Step 3/5: Verify Samples");
       Terminal.WriteLine("===============================================================================");
       VerifySamplesCommand.Handler verifySamplesHandler = new(Terminal);
       await verifySamplesHandler.Handle(new VerifySamplesCommand(), CancellationToken.None);
 
+      if (StopOnFailure("Verify Samples"))
+      {
+        return;
+      }
+
       Terminal.WriteLine("");
       Terminal.WriteLine("===============================================================================");
       Terminal.WriteLine("  Step 4/5: Test");
       Terminal.WriteLine("===============================================================================");
       TestCommand.Handler testHandler = new();
       await testHandler.Handle(new TestCommand(), CancellationToken.None);
 
+      if (StopOnFailure("Test"))
+      {
+        return;
+      }
+
       Terminal.WriteLine("");
       Terminal.WriteLine("===============================================================================");
       Terminal.WriteLine("  Step 5/5: Check Version");
       Terminal.WriteLine("===============================================================================");
       CheckVersionCommand.Handler checkVersionHandler = new(Terminal);
       await checkVersionHandler.Handle(new CheckVersionCommand(), CancellationToken.None);
 
-      if (Environment.ExitCode != 0)
+      if (StopOnFailure("Check Version"))
       {
-        Terminal.WriteErrorLine("");
-        Terminal.WriteErrorLine("===============================================================================");
-        Terminal.WriteErrorLine("  Pipeline FAILED - Version check failed");
-        Terminal.WriteErrorLine("===============================================================================");
         return;
       }
 
@@ -143,6 +161,8 @@ private async Task RunReleaseWorkflowAsync(string? apiKey)
       Terminal.WriteLine("Pipeline: clean -> build -> push");
       Terminal.WriteLine("");
 
+      Environment.ExitCode = 0;
+
       string? repoRoot = Git.FindRoot();
       if (repoRoot == null)
       {
@@ -157,25 +177,31 @@ private async Task RunReleaseWorkflowAsync(string? apiKey)
       CleanCommand.Handler cleanHandler = new();
       await cleanHandler.Handle(new CleanCommand(), CancellationToken.None);
 
+      if (StopOnFailure("Clean"))
+      {
+        return;
+      }
+
       Terminal.WriteLine("");
       Terminal.WriteLine("===============================================================================");
       Terminal.WriteLine("  Step 2/3: Build");
       Terminal.WriteLine("===============================================================================");
       BuildCommand.Handler buildHandler = new();
       await buildHandler.Handle(new BuildCommand(), CancellationToken.None);
 
+      if (StopOnFailure("Build"))
+      {
+        return;
+      }
+
       Terminal.WriteLine("");
       Terminal.WriteLine("===============================================================================");
       Terminal.WriteLine("  Step 3/3: Push to NuGet");
       Terminal.WriteLine("===============================================================================");
       await PushPackageAsync(repoRoot, apiKey);
 
-      if (Environment.ExitCode != 0)
+      if (StopOnFailure("Push to NuGet"))
       {
-        Terminal.WriteErrorLine("");
-        Terminal.WriteErrorLine("===============================================================================");
-        Terminal.WriteErrorLine("  Pipeline FAILED - Package push failed");
-        Terminal.WriteErrorLine("===============================================================================");
         return;
       }
 
@@ -229,6 +255,20 @@ private async Task PushPackageAsync(string repoRoot, string? apiKey)
 
       Terminal.WriteLine("\n✅ Package pushed successfully!");
     }
+
+    private bool StopOnFailure(string stepName)
+    {
+      if (Environment.ExitCode == 0)
+      {
+        return false;
+      }
+
+      Terminal.WriteErrorLine("");
+      Terminal.WriteErrorLine("===============================================================================");
+      Terminal.WriteErrorLine($"  Pipeline FAILED - {stepName} failed");
+      Terminal.WriteErrorLine("===============================================================================");
+      return true;
+    }
   }
 }