Skip to content

refactor: remove config dependency from RepoCheckVersionService#71

Merged
StevenTCramer merged 7 commits into
masterfrom
version-bump-beta.27
Mar 26, 2026
Merged

refactor: remove config dependency from RepoCheckVersionService#71
StevenTCramer merged 7 commits into
masterfrom
version-bump-beta.27

Conversation

@StevenTCramer

Copy link
Copy Markdown
Contributor

Summary

  • Removed config-related files from Amuru (public repo no longer references private "ganda" branding)
  • Refactored IRepoCheckVersionService to expose two focused methods instead of one strategy-switching method
  • Removed IRepoConfigService dependency from RepoCheckVersionService

Changes

Deleted files:

  • IRepoConfigService.cs
  • RepoConfigService.cs
  • RepoConfig.cs
  • RepoConfigJsonContext.cs

API changes:

Before:

Task<CheckVersionResult> CheckAsync(string? strategy, string? package, string? tag, ...);

After:

Task<GitTagCheckResult> CheckGitTagVersionAsync(string? tag = null, CancellationToken = default);
Task<NuGetCheckResult> CheckNuGetVersionAsync(IReadOnlyList<string> packages, CancellationToken = default);

Test results

All 8 tests pass.

Follow-up

This is step 1 of a larger migration:

  1. ✅ Refactor Amuru (this PR)
  2. Release new Amuru version
  3. Nuru.DevCli updates to use new Amuru
  4. Amuru's dev-cli updates to use Nuru.DevCli shared endpoints

Note: The dev-cli check-version command in this repo still uses the old API and will be updated in step 4.

- Delete IRepoConfigService, RepoConfigService, RepoConfig, RepoConfigJsonContext
- Remove 'ganda' branding leak from public repo
- Split IRepoCheckVersionService into two focused methods:
  - CheckGitTagVersionAsync(string? tag) -> GitTagCheckResult
  - CheckNuGetVersionAsync(IReadOnlyList<string> packages) -> NuGetCheckResult
- Remove strategy switching, use direct method calls
- Update tests to use new API
- Delete repo-config-service tests (tests deleted code)
@StevenTCramer StevenTCramer merged commit 05c5632 into master Mar 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant