refactor: remove config dependency from RepoCheckVersionService

kanban/done/079-refactor-repocheckversionservice-remove-config-dependency-split-into-two-methods.md

@@ -0,0 +1,159 @@
+# Refactor RepoCheckVersionService - remove config dependency, split into two methods
+
+## Description
+
+Remove config-related files from Amuru (public repo should not reference private "ganda" branding) and refactor `IRepoCheckVersionService` to expose two focused methods instead of one strategy-switching method.
+
+## Checklist
+
+- [x] Delete config-related files from Amuru
+  - [x] `source/timewarp-amuru/repo/IRepoConfigService.cs`
+  - [x] `source/timewarp-amuru/repo/RepoConfigService.cs`
+  - [x] `source/timewarp-amuru/repo/RepoConfig.cs`
+  - [x] `source/timewarp-amuru/repo/RepoConfigJsonContext.cs`
+- [x] Rewrite `IRepoCheckVersionService.cs`
+  - [x] Remove `CheckVersionResult` record
+  - [x] Add `GitTagCheckResult` record
+  - [x] Add `NuGetCheckResult` record
+  - [x] Replace `CheckAsync` with `CheckGitTagVersionAsync(string? tag = null, CancellationToken)`
+  - [x] Add `CheckNuGetVersionAsync(IReadOnlyList<string> packages, CancellationToken)`
+- [x] Rewrite `RepoCheckVersionService.cs`
+  - [x] Remove `IRepoConfigService` dependency from constructor
+  - [x] Remove config reading from `CheckAsync`
+  - [x] Split into two methods matching the interface
+  - [x] `CheckGitTagVersionAsync` — no package param, optional tag
+  - [x] `CheckNuGetVersionAsync` — required `IReadOnlyList<string> packages`
+- [x] Update tests in `tests/timewarp-amuru/single-file-tests/repo-services/`
+  - [x] Delete `MockRepoConfigService` from test file
+  - [x] Update tests to call `CheckGitTagVersionAsync` or `CheckNuGetVersionAsync` directly
+  - [x] Update assertions for new result types
+
+## Notes
+
+### Problem Statement
+
+Amuru is a **public** repo but contains references to "ganda" (a private internal tool):
+- `RepoConfigService` reads from `.timewarp/ganda.jsonc`
+- This leaks private branding into public code
+
+Additionally, the config service is an **application concern**, not a library concern. Amuru provides primitives (process execution, shell commands) but shouldn't dictate how applications configure themselves.
+
+### Design Decision: Two Methods vs Strategy Switching
+
+**Before:**
+```csharp
+Task<CheckVersionResult> CheckAsync(string? strategy, string? package, string? tag, ...);
+// String-based dispatch, params that only apply to one strategy
+```
+
+**After:**
+```csharp
+Task<GitTagCheckResult> CheckGitTagVersionAsync(string? tag = null, CancellationToken = default);
+Task<NuGetCheckResult> CheckNuGetVersionAsync(IReadOnlyList<string> packages, CancellationToken = default);
+// Direct method call, type-safe params, focused result types
+```
+
+### New Result Types
+
+```csharp
+public sealed record GitTagCheckResult
+(
+  bool IsNewVersion,
+  string Version,
+  string? LatestReleaseTag
+);
+
+public sealed record NuGetCheckResult
+(
+  bool IsNewVersion,
+  string Version,
+  string? LatestNuGetVersion,
+  IReadOnlyList<string> CheckedPackages,
+  IReadOnlyList<string>? AlreadyPublishedPackages
+);
+```
+
+### Caller Example
+
+```csharp
+// Git tag check
+GitTagCheckResult result = await CheckVersionService.CheckGitTagVersionAsync(cancellationToken: ct);
+
+// NuGet check
+string[] packages = ["TimeWarp.Amuru", "TimeWarp.Nuru"];
+NuGetCheckResult result = await CheckVersionService.CheckNuGetVersionAsync(packages, ct);
+```
+
+### Files to Delete
+
+| File | Reason |
+|------|--------|
+| `IRepoConfigService.cs` | Config policy doesn't belong in Amuru |
+| `RepoConfigService.cs` | Hardcoded `.timewarp/ganda.jsonc` path |
+| `RepoConfig.cs` | Application-level config schema |
+| `RepoConfigJsonContext.cs` | Serialization for app config |
+
+### Follow-up Sequence
+
+This task is step 1 of a larger migration:
+
+```
+1. Refactor Amuru (this task)
+       │
+       ▼
+2. Release new Amuru version
+       │
+       ▼
+3. Nuru.DevCli updates to use new Amuru
+       │
+       ▼
+4. Amuru's dev-cli updates to use Nuru.DevCli shared endpoints
+```
+
+**NOT in this task:**
+- Updating Amuru's `tools/dev-cli/endpoints/check-version-command.cs` (step 4)
+- Updating Nuru dev-cli (step 3)
+
+The dev-cli updates happen after Nuru.DevCli consumes the new Amuru release.
+
+## Results
+
+### What was implemented
+
+- Removed all config-related files from Amuru (public repo no longer references private "ganda" branding)
+- Refactored `IRepoCheckVersionService` to expose two focused methods instead of one strategy-switching method
+- Removed `IRepoConfigService` dependency from `RepoCheckVersionService`
+- Updated all tests to use the new API
+
+### Files changed
+
+**Deleted:**
+- `source/timewarp-amuru/repo/IRepoConfigService.cs`
+- `source/timewarp-amuru/repo/RepoConfigService.cs`
+- `source/timewarp-amuru/repo/RepoConfig.cs`
+- `source/timewarp-amuru/repo/RepoConfigJsonContext.cs`
+- `tests/timewarp-amuru/single-file-tests/repo-services/repo-config-service.cs`
+
+**Modified:**
+- `source/timewarp-amuru/repo/IRepoCheckVersionService.cs` — new result types, two methods
+- `source/timewarp-amuru/repo/RepoCheckVersionService.cs` — removed config dependency, split into two methods
+- `tests/timewarp-amuru/single-file-tests/repo-services/repo-check-version-service.cs` — updated for new API
+
+### Key decisions
+
+- `CheckNuGetVersionAsync` requires `IReadOnlyList<string> packages` (not optional)
+- `CheckGitTagVersionAsync` has no package parameter, only optional `tag`
+- Each method returns a focused result type (`GitTagCheckResult` or `NuGetCheckResult`)
+- Removed `Strategy` field from results — method name tells you the strategy
+
+### Test outcomes
+
+All 8 tests pass:
+- Constructor_WithValidDependencies_ShouldSucceed
+- CheckGitTagVersionAsync_WhenNotInGitRepo_ShouldReturnFalse
+- CheckGitTagVersionAsync_ShouldCompareVersions
+- CheckGitTagVersionAsync_WhenGitTagExists_ShouldReturnIsNewVersionFalse
+- CheckGitTagVersionAsync_WhenGitTagDoesNotExist_ShouldReturnIsNewVersionTrue
+- CheckNuGetVersionAsync_WhenVersionIsNew_ShouldReturnTrue
+- CheckNuGetVersionAsync_WhenVersionExists_ShouldReturnFalse
+- CheckNuGetVersionAsync_WithEmptyPackages_ShouldReturnFalse

source/Directory.Build.props

@@ -5,7 +5,7 @@
   <!-- Default package metadata (can be overridden in individual projects) -->
   <PropertyGroup Label="Package Metadata">
     <IsPackable>true</IsPackable>
-    <Version>1.0.0-beta.27</Version>
+    <Version>1.0.0-beta.28</Version>
     <Authors>Steven T. Cramer</Authors>
     <RepositoryUrl>https://github.com/TimeWarpEngineering/timewarp-amuru</RepositoryUrl>
     <PackageLicenseExpression>Unlicense</PackageLicenseExpression>

source/timewarp-amuru/repo/IRepoCheckVersionService.cs

@@ -5,16 +5,24 @@
 namespace TimeWarp.Amuru;
 
 /// <summary>
-/// Result of a version check operation.
+/// Result of a git tag version check operation.
 /// </summary>
-public sealed record CheckVersionResult
+public sealed record GitTagCheckResult
+(
+  bool IsNewVersion,
+  string Version,
+  string? LatestReleaseTag
+);
+
+/// <summary>
+/// Result of a NuGet version check operation.
+/// </summary>
+public sealed record NuGetCheckResult
 (
   bool IsNewVersion,
   string Version,
-  string Strategy,
-  string? LatestReleaseTag,
   string? LatestNuGetVersion,
-  IReadOnlyList<string>? CheckedPackages,
+  IReadOnlyList<string> CheckedPackages,
   IReadOnlyList<string>? AlreadyPublishedPackages
 );
 
@@ -24,18 +32,18 @@ public sealed record CheckVersionResult
 public interface IRepoCheckVersionService
 {
   /// <summary>
-  /// Checks if the current version is new and can be published.
+  /// Checks if the current version is new compared to git tags.
+  /// </summary>
+  /// <param name="tag">Specific tag to check (optional, uses GITHUB_REF_NAME or latest git tag if not provided)</param>
+  /// <param name="cancellationToken">Cancellation token</param>
+  /// <returns>The result of the git tag version check</returns>
+  Task<GitTagCheckResult> CheckGitTagVersionAsync(string? tag = null, CancellationToken cancellationToken = default);
+
+  /// <summary>
+  /// Checks if the current version is new compared to NuGet packages.
   /// </summary>
-  /// <param name="strategy">The version check strategy (git-tag or nuget-search)</param>
-  /// <param name="package">Specific package to check (for nuget-search strategy)</param>
-  /// <param name="tag">Specific tag to check (for git-tag strategy)</param>
+  /// <param name="packages">List of packages to check</param>
   /// <param name="cancellationToken">Cancellation token</param>
-  /// <returns>The result of the version check</returns>
-  Task<CheckVersionResult> CheckAsync
-  (
-    string? strategy = null,
-    string? package = null,
-    string? tag = null,
-    CancellationToken cancellationToken = default
-  );
+  /// <returns>The result of the NuGet version check</returns>
+  Task<NuGetCheckResult> CheckNuGetVersionAsync(IReadOnlyList<string> packages, CancellationToken cancellationToken = default);
 }