refactor: validate constraint name

Author: triceo

java/task-assigning/src/main/java/org/acme/taskassigning/domain/Employee.java

@@ -102,8 +102,8 @@ public Affinity getAffinity(Customer customer) {
     }
 
     @JsonIgnore
-    public Integer getEndTime() {
-        return tasks.isEmpty() ? 0 : tasks.get(tasks.size() - 1).getEndTime();
+    public long getEndTime() {
+        return tasks.isEmpty() ? 0L : tasks.get(tasks.size() - 1).getEndTime();
     }
 
     @Override

java/task-assigning/src/main/java/org/acme/taskassigning/domain/Task.java

@@ -20,7 +20,7 @@ public class Task {
     private TaskType taskType;
     private int indexInTaskType;
     private Customer customer;
-    private int minStartTime;
+    private long minStartTime;
     private Priority priority;
 
     // Shadow variables
@@ -32,7 +32,7 @@ public class Task {
     private Task previousTask;
     // Not ignored, used in the UI.
     @ShadowVariable(supplierName = "startTimeSupplier")
-    private Integer startTime; // In minutes
+    private Long startTime; // In minutes
 
     public Task() {
     }
@@ -88,11 +88,11 @@ public void setCustomer(Customer customer) {
         this.customer = customer;
     }
 
-    public int getMinStartTime() {
+    public long getMinStartTime() {
         return minStartTime;
     }
 
-    public void setMinStartTime(int minStartTime) {
+    public void setMinStartTime(long minStartTime) {
         this.minStartTime = minStartTime;
     }
 
@@ -120,11 +120,11 @@ public void setPreviousTask(Task previousTask) {
         this.previousTask = previousTask;
     }
 
-    public Integer getStartTime() {
+    public Long getStartTime() {
         return startTime;
     }
 
-    public void setStartTime(Integer startTime) {
+    public void setStartTime(Long startTime) {
         this.startTime = startTime;
     }
 
@@ -134,11 +134,11 @@ public void setStartTime(Integer startTime) {
 
     @SuppressWarnings("unused")
     @ShadowSources({"employee", "previousTask.startTime"})
-    public Integer startTimeSupplier() {
+    public Long startTimeSupplier() {
         if (employee == null) {
             return null;
         } else if (previousTask == null) {
-            return minStartTime;
+            return (long) minStartTime;
         } else {
             var previousEndTime = previousTask.getEndTime();
             return Math.max(previousEndTime, minStartTime);
@@ -160,7 +160,7 @@ public int getMissingSkillCount() {
     }
 
     @JsonIgnore
-    public int getDuration() {
+    public long getDuration() {
         Affinity affinity = getAffinity();
         return taskType.getBaseDuration() * affinity.getDurationMultiplier();
     }
@@ -171,7 +171,7 @@ public Affinity getAffinity() {
     }
 
     @JsonIgnore
-    public Integer getEndTime() {
+    public Long getEndTime() {
         if (startTime == null) {
             return null;
         }

java/task-assigning/src/main/java/org/acme/taskassigning/domain/TaskType.java

@@ -11,7 +11,7 @@ public class TaskType {
 
     private String code;
     private String title;
-    private int baseDuration; // In minutes
+    private long baseDuration; // In minutes
     private List<String> requiredSkills;
 
     public TaskType() {
@@ -47,11 +47,11 @@ public void setTitle(String title) {
         this.title = title;
     }
 
-    public int getBaseDuration() {
+    public long getBaseDuration() {
         return baseDuration;
     }
 
-    public void setBaseDuration(int baseDuration) {
+    public void setBaseDuration(long baseDuration) {
         this.baseDuration = baseDuration;
     }
 

java/task-assigning/src/main/java/org/acme/taskassigning/solver/TaskAssigningConstraintProvider.java

@@ -52,7 +52,7 @@ protected Constraint minimizeMakespan(ConstraintFactory constraintFactory) {
         return constraintFactory.forEach(Employee.class)
                 .penalize(BendableScore.ofSoft(BENDABLE_SCORE_HARD_LEVELS_SIZE, BENDABLE_SCORE_SOFT_LEVELS_SIZE, 1, 1),
                         employee -> employee.getEndTime() * employee.getEndTime())
-                .asConstraint("Minimize makespan, latest ending employee first");
+                .asConstraint("Minimize makespan - latest ending employee first");
     }
 
     protected Constraint criticalPriorityTaskEndTime(ConstraintFactory constraintFactory) {

java/task-assigning/src/test/java/org/acme/taskassigning/solver/TaskAssigningConstraintProviderTest.java

@@ -70,7 +70,7 @@ void criticalPriorityTaskEndTime() {
         // Task 1
         TaskType type1 = new TaskType("1", "1", 10);
         Task task1 = new Task("1", type1, 1, customer, employee, 1, Priority.CRITICAL);
-        task1.setStartTime(1);
+        task1.setStartTime(1L);
         // Task 2
         TaskType type2 = new TaskType("1", "1", 20);
         Task task2 = new Task("2", type2, 1, customer, employee, 2, Priority.MINOR);
@@ -90,15 +90,15 @@ void minimizeMakespan() {
         // Task 1
         TaskType type1 = new TaskType("1", "1", 10);
         Task task1 = new Task("1", type1, 1, customer, employee1, 1, Priority.CRITICAL);
-        task1.setStartTime(1);
+        task1.setStartTime(1L);
         // Task 2
         TaskType type2 = new TaskType("2", "1", 20);
         Task task2 = new Task("2", type2, 1, customer, employee1, 2, Priority.MINOR);
-        task2.setStartTime(2);
+        task2.setStartTime(2L);
         // Task 3
         TaskType invalidType2 = new TaskType("3", "3", 1);
         Task task3 = new Task("3", invalidType2, 1, customer, employee2, 1, Priority.CRITICAL);
-        task3.setStartTime(3);
+        task3.setStartTime(3L);
 
         employee1.setTasks(List.of(task1, task2));
         employee2.setTasks(List.of(task3));
@@ -116,7 +116,7 @@ void majorPriorityTaskEndTime() {
         // Task 1
         TaskType type1 = new TaskType("1", "1", 10);
         Task task1 = new Task("1", type1, 1, customer, employee, 1, Priority.MAJOR);
-        task1.setStartTime(1);
+        task1.setStartTime(1L);
         // Task 2
         TaskType type2 = new TaskType("1", "1", 20);
         Task task2 = new Task("2", type2, 1, customer, employee, 2, Priority.MINOR);
@@ -134,7 +134,7 @@ void minorPriorityTaskEndTime() {
         // Task 1
         TaskType type1 = new TaskType("1", "1", 10);
         Task task1 = new Task("1", type1, 1, customer, employee, 1, Priority.MINOR);
-        task1.setStartTime(1);
+        task1.setStartTime(1L);
         // Task 2
         TaskType type2 = new TaskType("1", "1", 20);
         Task task2 = new Task("2", type2, 1, customer, employee, 2, Priority.MAJOR);