Leftovers#1028
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR applies API changes from upstream Timefold Solver repositories, updating the codebase to use the simplified SolverManager API that no longer requires an explicit problem ID type parameter. The changes affect multiple scheduling examples across Java and Kotlin implementations.
Changes:
- Updated
SolverManagertype declarations to remove the problem ID type parameter (changed fromSolverManager<Solution, String>toSolverManager<Solution>) - Reordered imports in Java files to follow standard conventions (Java standard library imports before third-party imports)
- Modified exception handlers and problem finders to work with the new generic
Object/Anyproblem ID type, adding explicit casts where the ID is used - Changed time-related types from
int/Integertolong/Longin the task-assigning domain model - Minor constraint name formatting update
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| kotlin/school-timetabling/.../TimetableResource.kt | Updated SolverManager type, reordered imports, changed problem finder and exception handler to use Any type |
| java/vehicle-routing/.../VehicleRoutePlanResource.java | Removed String type parameter from SolverManager |
| java/tournament-scheduling/.../TournamentSchedulingResource.java | Updated SolverManager, reordered imports, added cast in exception handler |
| java/task-assigning/.../TaskAssigningConstraintProviderTest.java | Changed setStartTime calls to use Long literals (1L, 2L, 3L) |
| java/task-assigning/.../TaskAssigningConstraintProvider.java | Updated constraint name formatting (comma to dash) |
| java/task-assigning/.../TaskAssigningResource.java | Updated SolverManager, reordered imports, added cast in exception handler |
| java/task-assigning/.../TaskType.java | Changed getBaseDuration return type from int to long |
| java/task-assigning/.../Task.java | Changed startTime, endTime types from Integer/int to Long/long |
| java/task-assigning/.../Employee.java | Changed getEndTime return type from Integer to long |
| java/spring-boot-integration/.../TimetableController.java | Removed String type parameter from SolverManager |
| java/sports-league-scheduling/.../SportsLeagueSchedulingResource.java | Updated SolverManager, reordered imports, added cast in exception handler |
| java/school-timetabling/.../TimetableResource.java | Removed String type parameter from SolverManager |
| java/project-job-scheduling/.../ProjectJobSchedulingResource.java | Updated SolverManager, reordered imports, added cast in exception handler |
| java/order-picking/.../OrderPickingSolverResource.java | Removed String type parameter from SolverManager |
| java/meeting-scheduling/.../MeetingSchedulingResource.java | Updated SolverManager, reordered imports, added cast in exception handler |
| java/maintenance-scheduling/.../MaintenanceScheduleResource.java | Removed String type parameter from SolverManager |
| java/food-packaging/.../PackagingScheduleResource.java | Removed String type parameter from SolverManager |
| java/flight-crew-scheduling/.../FlightCrewSchedulingResource.java | Updated SolverManager, reordered imports, added cast in exception handler |
| java/facility-location/.../SolverManagerTest.java | Removed Long type parameter from SolverManager |
| java/facility-location/.../SolverResource.java | Removed String type parameter from SolverManager |
| java/employee-scheduling/.../EmployeeScheduleResource.java | Removed String type parameter from SolverManager |
| java/conference-scheduling/.../ConferenceSchedulingResource.java | Updated SolverManager, reordered imports, added cast in exception handler |
| java/bed-allocation/.../BedSchedulingResource.java | Updated SolverManager, reordered imports, added cast in exception handler |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zepfred
approved these changes
Feb 23, 2026
zepfred
left a comment
zepfred
left a comment
Contributor
There was a problem hiding this comment.
There is a suggestion to change the key type on the problem map, which will also require a chang on the endpoint list(). That's not a blocker to approve it, though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Counterpart to:
TimefoldAI/timefold-solver#2136
https://github.com/TimefoldAI/timefold-solver-enterprise/pull/457