Skip to content

chore: no score analysis in facility location status#1061

Merged
triceo merged 1 commit into
TimefoldAI:developmentfrom
triceo:noanalysis
Apr 20, 2026
Merged

chore: no score analysis in facility location status#1061
triceo merged 1 commit into
TimefoldAI:developmentfrom
triceo:noanalysis

Conversation

@triceo

@triceo triceo commented Apr 20, 2026

Copy link
Copy Markdown
Collaborator

Description of the change

Description here

Checklist

Development

  • The changes have been covered with tests, if necessary.
  • You have a green build, with the exception of the flaky tests.
  • UI and JS files are fully tested, the user interface works for all modules affected by your changes (e.g., solve and analyze buttons).
  • The network calls work for all modules affected by your changes (e.g., solving a problem).
  • The console messages are validated for all modules affected by your changes.

Code Review

  • This pull request includes an explanatory title and description.
  • The GitHub issue is linked.
  • At least one other engineer has approved the changes.
  • After PR is merged, inform the reporter.

@triceo
triceo requested a review from TomCools as a code owner April 20, 2026 06:15
Copilot AI review requested due to automatic review settings April 20, 2026 06:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes score analysis from the facility-location /flp/status response by dropping the scoreExplanation field from the Status DTO, shifting score analysis usage to the dedicated /flp/analyze endpoint.

Changes:

  • Removed scoreExplanation from Status response payload.
  • Updated SolverResource.statusFromSolution() to stop calling solutionManager.analyze(...).summarize() on every status request.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
java/facility-location/src/main/java/org/acme/facilitylocation/rest/Status.java Removes scoreExplanation from the serialized status DTO.
java/facility-location/src/main/java/org/acme/facilitylocation/rest/SolverResource.java Stops computing score analysis summary during status polling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@triceo
triceo merged commit fc1e66d into TimefoldAI:development Apr 20, 2026
46 of 49 checks passed
@triceo
triceo deleted the noanalysis branch April 20, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants